Message-ID: <298da104-14ee-45dd-0919-fb847fd34354@intel.com>
Date:   Mon, 13 Dec 2021 14:06:48 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.0
Subject: Re: [PATCH 01/25] x86/sgx: Add shortlog descriptions to ENCLS
 wrappers
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <dave.hansen@linux.intel.com>, <tglx@linutronix.de>,
        <bp@alien8.de>, <luto@kernel.org>, <mingo@redhat.com>,
        <linux-sgx@vger.kernel.org>, <x86@kernel.org>, <seanjc@google.com>,
        <kai.huang@intel.com>, <cathy.zhang@intel.com>,
        <cedric.xing@intel.com>, <haitao.huang@intel.com>,
        <mark.shanahan@intel.com>, <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>
References: <cover.1638381245.git.reinette.chatre@intel.com>
 <fd9ab4d760a2ea7a42ab9e60b9e19b8620abe11d.1638381245.git.reinette.chatre@intel.com>
 <YauzxOEmmpeGF/K3@iki.fi> <b49ee68b-63c5-f8f8-ca2b-31663c3150f6@intel.com>
 <b6eeb67d3be33767a4d52d8e2009817a90d91224.camel@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <b6eeb67d3be33767a4d52d8e2009817a90d91224.camel@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGQ5QUgvaVBack8yOE1LdGZpT25lRU9YcVZiVnJ2aWV2c1p0cUd4TFQvR0JX?=
 =?utf-8?B?bnZ5bjVhTTFXYm5LMW4xV3BmbUJmcXFvZVZKQ3l5ZmZ4eXNrWTI4YmVCa3Zt?=
 =?utf-8?B?TTNZYzVOeGRnLyszZThKY3pSQkhiMmgrRVBSMDN5ZUNKajJSZCtkUDdDaFA3?=
 =?utf-8?B?U3B3VURleURLaCt1U3lObDV6THJ2WnlqTCtZZFVlZk5PQ2NIQytETWZzdFZa?=
 =?utf-8?B?bUtZZUFCU1ZJbEVDb1FHb2R6UEN5V1pXd3VVbzd5bTJCeWVvWThvcGZ1K3oz?=
 =?utf-8?B?S0ltZEVLK3hxZ0Q5WnpOS0x2aWtabUxieWIrRHFnYlY1b1JYSmJRV0dBT3Rj?=
 =?utf-8?B?TFRMY0t6Y0ZxRXRNK0J5aU83a3FaUGdOYitsUS84TG5OSXBOaGlnbDVFVzJT?=
 =?utf-8?B?dmtWZkxESUNob1VjNlNIaTBmVFovelJRNXlJcUthM082SGlQd3FDS0JHM2dD?=
 =?utf-8?B?enRoVXBqYVI5Q0p2L1h0RGdhbHFiSjNjZ2J0RGU4emlNUjREYktqTVVkdGZM?=
 =?utf-8?B?ZVFibGdGUjVsVjZwOTdpZ2paQVdTOFhXS05TcklTeHZUN3hKak55ZnF2WnVu?=
 =?utf-8?B?anpRWE9ac21DSHRZNCtkZkRjZ1VhQTRSZmRoU013ZllkYmxidmtWQ0ppRU03?=
 =?utf-8?B?WVpCZlZVNUw2TWQyazhVL2cvV3lIUU1JdEdjTUtvRXpDblhmcm9ZL09ublRI?=
 =?utf-8?B?L3R5L0lQWTJ0MHZiUzZXNWVDSG9uQXR1YTZ1VDlWVU80ZTI0RnNuMnVDWHVN?=
 =?utf-8?B?c05OSXoxTmI1by9RZ0ppcnVaNWlrZjdJM255SU84Mzg3c3YzL0kxYWxocm8x?=
 =?utf-8?B?MmtkOHRMYjF1SjY4Q1ZOekxlblVkREhSZXZoOGhsVFlzR2c5dnBDS2ZVd2s1?=
 =?utf-8?B?aUFaOGRlSmpYbktzM0Rhbkd3QWtxL0tUYWVZZUFPN0NYZTZ3TmNZNlE0K3ht?=
 =?utf-8?B?ZFZITG9WM1pRTER1T3FqanlnV3dpM1E1Y0xXUWMxRTZYNTZhbytvNjFVemxk?=
 =?utf-8?B?Z2RiSVlheS83ZUwyakpiWnNVZmRGd0Rjb29tY3V3UlE0REdxTnNhVnlIVVBS?=
 =?utf-8?B?WXN6RHFtOTB0TkJVa1B0bzJSV0NWTDJJWm9LdXRBU3pMNEpSUlR0MTdCUTF4?=
 =?utf-8?B?bmpraFFhbFBwNU1iUk5yVGt6aWc2Mno3UnJaZ3BzZ2ptUGg0Q2ZBdDFUVk1O?=
 =?utf-8?B?ZlZVVmlMdWNuQlRLOGkvWkdDQ1hqZ2FCMTVFVEFHd0ZuNEYxT2d2RHJpMzdQ?=
 =?utf-8?B?Tks1cnU3QVl0cWs5N1pocjU4UmxMYVdoQmJ6bEQ5R0pKVTJnUnhJN0tZdkRr?=
 =?utf-8?B?T1IyZUxZQkVDcnlVYWZqUjA4VlNOK1BiM2Z6TGdBMW9ETmtoN0pFNisyd3hR?=
 =?utf-8?B?NkVqdS9oVTYrbEhMdFQ4bVUwYm9rblQ2WWhQRjZPZXZ1aC93Y0lGOU9QUWdN?=
 =?utf-8?B?cTFUc0NjelBaUUZvMnhHRTJPQUl3OUppK1gzK0Rlcm1EamVaVFVNNjIzN1FF?=
 =?utf-8?B?b2JTV29uZ04zTmJjYWdOaTJJN3NWT1dyOTk2QmcydFlsejJiTWhFR01LSkVU?=
 =?utf-8?B?aVhnQjhJU3pEUFFxMTBuTE04SjBKVFlXam9qdWJKckhaT1owMDVERVNSMzJw?=
 =?utf-8?B?bm8ya2VwZmVZVzlWZ0ZRWXJ6NGZQek9ya0JPK2QxTzd1TXFYUng2L2RVRWxo?=
 =?utf-8?B?WDl4NldmVWRFTmJHd0pLYklEYWxoTVdjR2plNTlPS002YTBpeCt6NDNKa1ZP?=
 =?utf-8?B?VWVxSmVreUtsUm50alRxaFFML2oyVUpndnU5SHJzS1Y5WC9tc1Y1WGF5V2hO?=
 =?utf-8?B?MnIxV3VGWUplNVhYTmhVY0M5L2hSZmNiTHJaL1NVU0FLUnFRaHVIekpJTi9m?=
 =?utf-8?B?NUsrekxqSW5CdWVZRDZtbTNPZFpCbWxuVGx5K1NLVExFbGRMaitIaTVrWmJN?=
 =?utf-8?B?QnE1RnpzZHRTZ2E2cDhrRmlJNGJHYTF6YWZiMkdrQWh6S1Z2eTFGNUtTOU93?=
 =?utf-8?B?OTJpMndhK2NTM1lsRkVVcHY1OWo2VEowKzhveFh6b1BQREI5ajZQMHM5bWxK?=
 =?utf-8?B?Mnd3YjlaY1pzb0phcFNyYWFlOUNZVHJHSHBZVTJzYi9HTlpXczhrODMvTjhG?=
 =?utf-8?B?SUNmRjR0VTJuZkV3NXRYM0JST25TMEZZSzN2Z0JzN0c4T01ydWRNYWFyYXov?=
 =?utf-8?B?b1BHaTdsWm83bkc0VFNkZlpIcGZkelJxaU0yZnFkcWh0OCtyUGFOb0ZjZXcx?=
 =?utf-8?Q?R6hVq8Edcn/FSpKRnG4Bj9M7y4hrFWAD3Sa4+0vikc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5ad116e-efe3-4f34-cf12-08d9be84deea
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 22:06:53.6836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l18runVwDnChMA58blfUCacwScT6O6EhP6Q5GjY9ydPxjs+7dUFMjybGrjn49gtEsmeLRkZBBIKVaOvSwJSad7EFRqHYIFDnvvKzAMwBJAc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5292
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 12/10/2021 9:28 PM, Jarkko Sakkinen wrote:
> On Mon, 2021-12-06 at 13:13 -0800, Reinette Chatre wrote:

...

>>
>> __eadd():
>> /* Copy a source page from non-enclave memory into the EPC. */
> 
> Perhaps:
> 
> /*
>   * Associate an EPC page to an enclave either as a REG or TCS page
>   * populated with the provided data.
>   */
> 
> This is more aligned with your description for __eremove().

I was trying to keep the descriptions as concise one-liners. I'll use 
the text you provide if you are ok with its line length being an exception.

...

>>
>> __eremove():
>> /* Disassociate EPC page from its enclave and mark it as unused. */

...

Reinette