Message-ID: <e934673b-8410-d3fe-f231-fef672050e2b@intel.com>
Date:   Mon, 13 Dec 2021 14:12:57 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.0
Subject: Re: [PATCH 13/25] x86/sgx: Support adding of pages to initialized
 enclave
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <dave.hansen@linux.intel.com>, <tglx@linutronix.de>,
        <bp@alien8.de>, <luto@kernel.org>, <mingo@redhat.com>,
        <linux-sgx@vger.kernel.org>, <x86@kernel.org>, <seanjc@google.com>,
        <kai.huang@intel.com>, <cathy.zhang@intel.com>,
        <cedric.xing@intel.com>, <haitao.huang@intel.com>,
        <mark.shanahan@intel.com>, <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>
References: <cover.1638381245.git.reinette.chatre@intel.com>
 <9ab661a845d242cb10a90ade997f8ebda33cc7c9.1638381245.git.reinette.chatre@intel.com>
 <Yav1/ZRX68cECD7a@iki.fi> <cc6ecffd-7d4b-0b15-eaf1-6f585e8b31be@intel.com>
 <ce00226feaa02dbc0f66f3f8aa7a243f61e410aa.camel@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ce00226feaa02dbc0f66f3f8aa7a243f61e410aa.camel@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkZJZnVCcXpIN2Eva1FjZm9hQUxnV3RhZ1d2SHlua2x2U0hYakg0b3FzMERL?=
 =?utf-8?B?RWpOUEh5aGhBWk5KTGVRQzEwSHU1cXJrRGlJQzFqZkNYWVhrTGsvdlJWQU5C?=
 =?utf-8?B?RkI4K3M3ZHdqbmwvYXBTSVJlT1JEZTV0MkFIQmtrZHpGbzJPcVNVSDhDM0I0?=
 =?utf-8?B?Y1lHQnNHNjBuMGpIWW1JbEFkUnNMOGRmUHFUNTV0NHFkK0xXUEZrNnJCUXhw?=
 =?utf-8?B?aW5rRXZvVjFXNmpoTnVpR1BUKytxU3lUL29IeFZpQ3dGS1F5ZEJJSVZ1Smlz?=
 =?utf-8?B?K1paWVRDV0FhT2ZMMjMwUm54K0ZmZThGb25HbG0wZUNRVlBkbWRZaUZCdmZt?=
 =?utf-8?B?WWpZTUVIcmxHd1pDUlo1b1N4THcxSlNndEJ0bFZvUEluUlg0MS8zbTltUzB6?=
 =?utf-8?B?M0FTeU02dVVqR3RzbnRBdm1pNGIxdkNzOUtEOHhKQXoveTQ4TFN4TkRNaVZh?=
 =?utf-8?B?ZURlVjRZRnovZ1psTEJCT1NDSG1iNDc3NTV0aGVkUUE5WVRWU3I3RFFVNWtF?=
 =?utf-8?B?U21kbGVQSnNFQWZIU2RXWENJNkRZTlNKbzBRSUEzQWNDdDRrY1QzRFZ0U0ky?=
 =?utf-8?B?cHlTRE8zZ1FKelIva01tQUtrVXhZWHgyYlRtZTBiZUxwNGVpT0dzdm5uTmVP?=
 =?utf-8?B?RTVjUWUwVXVUQkZTWTM3T2YxendwWWhKQUQxd296RWRHaXBjUGNwODhJY3oy?=
 =?utf-8?B?VUJvN3BWY2JjOUFxQzhhLzVLTkpzM0VNMjYrTVdBTTJlZXdiTzZ0UWZseFcy?=
 =?utf-8?B?bUkzWitCcGlvU3p0TWdxd0MrekkwdHo3N2FIemZZK0Z6b3JJSE9EZTg2Wlpi?=
 =?utf-8?B?b1Vra0RzcFZpUDJQSE9SRzZEU2NHVWVvSjZjb0w0MjdyOW44Sk4zd2NKMnpm?=
 =?utf-8?B?dFI5UDdzOWpQRzBReHZzT2xycDRXREVxeUpMdmtDS2dCd0FOaEdKVGlOQXd3?=
 =?utf-8?B?dU8ydTVwR2J1bnQ4aCsrM2MzaTUvTGk4MjJNYUZtNi9LNWZmVzlxOUgwc2Vk?=
 =?utf-8?B?ejR2cjM1SUFRcExGSGdlVDJXZmpUdGJtSUo1dVBWL25mRmRWMm5jdE9aZzhx?=
 =?utf-8?B?YjdOY3pELzFWakg3c1BVNkxzTzgvUjlzTFYyQmJIeGgvTVRRV2Y5VWw3U1dY?=
 =?utf-8?B?QW9PWFVWb2g3NzZRYWRnRlFmNC9PMjlKS2NOcG42OEx1WWR0ditvSGRFSmZB?=
 =?utf-8?B?azVkeDY1UmhCOEU3MStKdnZ0dFg2eUlLcnRMUno3dHJXMENIUXhldkZjanRG?=
 =?utf-8?B?VkwxRXdJc2ZmKzRvQWJiV1JlUHVhTmRnaVdocmZtdmZoR0oyVmlTdStzdlVM?=
 =?utf-8?B?RFpmaFlBK1R6MUxnYyswbG1nRE5KS2dTR1dLNjRBUXFETmd3Sm5yNkdTQTE3?=
 =?utf-8?B?cTVLcXgvbnpCY0tzdi9vRVA1bkZPMzljVlRrVUNGNmkrZC84UDNVU0xEdk0x?=
 =?utf-8?B?bE4zRGpVKzQyRm9CVyt5MXZMUVFuSFNzY3M1RGdYQytLdjBxcU1rejRDZGZS?=
 =?utf-8?B?WjlqM3BjMU9DRE12dEJYR1FPaTMrL0lrbEYzMXZLNmdYYkRkREJ5NzhrVVdN?=
 =?utf-8?B?ZlBUUkYzSnVFektOUEdiUHB6MEJ0RFpBV3ZhT2lNQ055NHY0MFoxVTlEOVlo?=
 =?utf-8?B?YWV5RVFaMnU4bnl5YmI3MTl3UFNNMFZDczFwRkRtTjRJSWN0QnlyRGQzUXRj?=
 =?utf-8?B?aFZVajFLOERIY0RsT3ArVm9iVzZ6MWo4eE14QU9PWTlnbXdsTzl5WDhkeXVs?=
 =?utf-8?B?bW9wU2sycDVqT3hVTU14Y0JldkxWVFo4azE4V3BHQ3hwVjRYODhxRFpza0Vz?=
 =?utf-8?B?OHk4dmxSRUNvQ2xyYWdORXlOVzdnRmFjeHZQZFplajhWRmZ1NmRnSkdkbks3?=
 =?utf-8?B?VERYSHBkYmUrcGcyY3N2K3RkalJhaHhhNGwwdmF4cHRUOWJ6TXpNcUJxZDE0?=
 =?utf-8?B?dGdpRFVMeE5QdEc1cXQzb2hEN3pOTVI5N2R5UnQrMElyNTFvUzN1ZnppZjRw?=
 =?utf-8?B?dkRTQlEzWVhsQzNOMUJLeXFYajhQRVZWaG9icmd4djQ3c1FtaExhelJ6ekRz?=
 =?utf-8?B?Y2VmVDFHaDZTaEo3Lzg4OW9BVXNiQXhKcEltTUJzS1hxalBiVU9lcm45UWtq?=
 =?utf-8?B?YTJxejB4QW9lamZIM2phL01nR1l6MnFldVB4Sk1HVTVjSk5hV040Rm1OeVZV?=
 =?utf-8?B?eURVUkpyUWhKRFFsK1QxTnZPNDJIOHVobUhYRGVjWWZhRmMveFZmQXJUZW1a?=
 =?utf-8?Q?rLQL0g8Cod8rkfveH4czWI3ePDG2c2+o4IHZj/Kkcs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a6c17f26-8536-4c65-99c9-08d9be85ba61
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 22:13:01.8453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KA7sfhOEmkC8g8ASzvQzPY/FsvtIc951vkGcQmKeRagEjRBtQDf9paVGUUU8E6aCkzZNP7c6xervdn6jylAmHiUChHeuQCmjY+413kfcC0Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1908
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 12/11/2021 12:00 AM, Jarkko Sakkinen wrote:
> On Mon, 2021-12-06 at 13:44 -0800, Reinette Chatre wrote:
>> On 12/4/2021 3:13 PM, Jarkko Sakkinen wrote:
>>> On Wed, Dec 01, 2021 at 11:23:11AM -0800, Reinette Chatre wrote:

...

>>>> Accessing an uninitialized address from outside the enclave also triggers
>>>> this flow but the page will remain in PENDING state until accepted from
>>>> within the enclave.
>>>
>>> What does it mean being in PENDING state, and more imporantly, what is
>>> PENDING state? What does a memory access within enclave cause when it
>>> touch a page within this state?
>>
>> The PENDING state is the enclave page state from the SGX hardware's
>> perspective. The OS uses the ENCLS[EAUG] SGX2 function to add a new page
>> to the enclave but from the SGX hardware's perspective it would be in a
>> PENDING state until the enclave accepts the page. An access to the page
>> in PENDING state would result in a page fault.
>>
>>
>>> I see a lot of text in the commit message but zero mentions about EPCM
>>> expect this one sudden mention about PENDING field without attaching
>>> it to anything concrete.
>>
>> My apologies - I will add this to this changelog. This matches your
>> request to describe the __eaug() wrapper introduced in patch 02/25.
>> Would you like me to duplicate this information here and in that patch
>> (a new patch dedicated to the __eaug() wrapper) or would you be ok if I
>> introduce the wrappers all together briefly as in the example you
>> provide and then detail the flows where the wrappers are used - like
>> this patch?
> 
> I think it would be a good place to describe these details in 02/25,
> and skip them in rest of the patches.
> 

Will do. I do think describing this amount of detail for the new SGX2 
functions would be too much for a single patch so I currently plan to 
split that (02/25) patch into a new patch per SGX2 instruction. Is that 
ok with you or would you like to keep it in a single patch?

Reinette