Message-ID: <be465db1-ed27-6111-71fb-9ef86b6ed6c0@kernel.org>
Date:   Tue, 14 Dec 2021 00:28:46 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v3 0/6] Add QCM2290 interconnect support
Content-Language: en-US
To:     Shawn Guo <shawn.guo@linaro.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211206075808.18124-1-shawn.guo@linaro.org>
From:   Georgi Djakov <djakov@kernel.org>
In-Reply-To: <20211206075808.18124-1-shawn.guo@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Shawn,

On 6.12.21 9:58, Shawn Guo wrote:
> The series begins with a separate cleanup on icc-rpm, followed by a few
> prep changes for QCM2290 support, and then adds bindings and
> interconnect driver for QCM2290 platform.

Thanks for working on this! I have applied patch 1/6. Please rebase the
rest on linux-next.

BR,
Georgi

> Changes for v3:
> - Update bindings to define child interconnect provider nodes
> 
> Changes for v2:
> - Drop unneeded include of <dt-bindings/clock/qcom,gcc-qcm2290.h> from
>    bindings.
> 
> Shawn Guo (6):
>    interconnect: icc-rpm: Use NOC_QOS_MODE_INVALID for qos_mode check
>    interconnect: icc-rpm: Define ICC device type
>    interconnect: icc-rpm: Add QNOC type QoS support
>    interconnect: icc-rpm: Support child NoC device probe
>    dt-bindings: interconnect: Add Qualcomm QCM2290 NoC support
>    interconnect: qcom: Add QCM2290 driver support
> 
>   .../bindings/interconnect/qcom,qcm2290.yaml   |  137 ++
>   drivers/interconnect/qcom/Kconfig             |    9 +
>   drivers/interconnect/qcom/Makefile            |    2 +
>   drivers/interconnect/qcom/icc-rpm.c           |   56 +-
>   drivers/interconnect/qcom/icc-rpm.h           |   14 +-
>   drivers/interconnect/qcom/msm8916.c           |    4 +-
>   drivers/interconnect/qcom/msm8939.c           |    5 +-
>   drivers/interconnect/qcom/qcm2290.c           | 1363 +++++++++++++++++
>   drivers/interconnect/qcom/sdm660.c            |    7 +-
>   .../dt-bindings/interconnect/qcom,qcm2290.h   |   94 ++
>   10 files changed, 1678 insertions(+), 13 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml
>   create mode 100644 drivers/interconnect/qcom/qcm2290.c
>   create mode 100644 include/dt-bindings/interconnect/qcom,qcm2290.h
>