Date:   Mon, 13 Dec 2021 16:47:48 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 03/40] x86/mm: Extend cc_attr to include AMD SEV-SNP
Message-ID: <YbfNlKtQR+ek/CTc@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-4-brijesh.singh@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210154332.11526-4-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X7en9DEPZpufE5s5kHEVnUhhL/eg6A2m8Cn6eF9rKo6i7lW7L1TPfu0Yi+EO?=
 =?us-ascii?Q?v8blhBCv5YuL0tfEMf83UiONe5IzO7whEauY8XXytRv4rAFboTGUy53sD86V?=
 =?us-ascii?Q?9VSAIBpWvUDGdAtt4Ybzl+Jyb8kA5P3YOnQYuN6vuZbhPCYhzoUlkiZnHytM?=
 =?us-ascii?Q?nvgFXuWA1Dytj/sntFF5l3eV9MgvkbLXZ0fkJVexj8m01Jokvup+Hiqnk+4y?=
 =?us-ascii?Q?74rhiCvJjQzT2A1K3lbblVEodZHpfxivOJG9Dt1IlPU+2bSSiK7ElCJclykD?=
 =?us-ascii?Q?TNzZoXHtxN2oGyAVMUaP4+pBUymjvRI/HFNXIL036CJ1WYPxDU8vp/K9jvr+?=
 =?us-ascii?Q?q7bY563ZI8Q3pYvzWqN9pVPZfIT8iGIg6eMcLidW4+QmZyovFZsxVqrfi0pG?=
 =?us-ascii?Q?PDy4GRFXjUvABFdycy1CyCBZCfm1QoDbHe7LpE0SUFo5hEEB1nS5Xd+SPF20?=
 =?us-ascii?Q?xL/FyRUYc4KAEZ+TO1g2ZQwcnIz1HEh1kmCG9bHre8t4NO0oEejyd2kA9pcl?=
 =?us-ascii?Q?O5ubPeCDGOVx7FkXtdRoe+3TqfR0In5YXzaiNRMe1e8kjKXpt2ZFlYoRf7dk?=
 =?us-ascii?Q?gA9ITqL1YkWmzbIpPmYXdN/lMGDEcgZhNTvS4uN+FNWfTQhOD/da8Q9QEx0Q?=
 =?us-ascii?Q?ba6zxFNOQ5ifNcrNcq8G7h4f6iNVkUQq4lf/BwlEQ/bkcfCbk6HlG0dwuJhL?=
 =?us-ascii?Q?/MCRvVeiJFr7x43y5MkOWjcJg8HtWckGq4iiis/KtDZsOPf3zhLhlOvfYsZt?=
 =?us-ascii?Q?z6WDcx6T3lt96knx01gaf/fmNMtdHlfuo+xnFfFK6/p5P0XNnsULU4BvoBJl?=
 =?us-ascii?Q?rHMuVufzjnEF3+03ICgaRSRQwy2gSP7gBMV+iT+lz7BNtPLbnA4Vq0+zDdyV?=
 =?us-ascii?Q?dEva1AXY1fgtqc7zbXIJH4DuVvLtesKA9qqmlmzseQOxdlAgizemqafIDUwn?=
 =?us-ascii?Q?cHGqqYOkRtW9q4FOkx3Y+L01SIV2uByXS+HJ0GOzSkMVW1FWa9JFP0GbHgr/?=
 =?us-ascii?Q?f9Nj5lthW2FhkYwNTZQoKW79txcW8rGBChRfXzUN9ZIpxBtmhoi91wVQe7d/?=
 =?us-ascii?Q?iyJp0IELpjjUo+YVGCoxZ9mxiX631BvVRz94YQ4xrMofd6x6bYbTsGelvm4/?=
 =?us-ascii?Q?hGSNmltBwQCT7kuQnSZiD+M9PqKIwNdGVneVkoeIs24LngiN/uX0F8637TeH?=
 =?us-ascii?Q?PpRirJ8qGBb3zTR6AnmcFCyMLVWEPtgCXflbD42hmUwTgG+p2iXa2MYTSz0h?=
 =?us-ascii?Q?SgpvkC4QYXgm2CaNisoLRWuZ+VQ1AgejQLjvLEjYdXHju8vJ38NSNkurwz/t?=
 =?us-ascii?Q?kTpjc9kemR6TVDMVUZ6bgG8tPTLVBkrKe+X2pGGEdtVIqlbEBDrlBrWMJW5g?=
 =?us-ascii?Q?7KdOIJ4hwdCWthAghf/TEoGTjBgYjq2QSCEAVG1hrbGqr30gASSRlWyfatks?=
 =?us-ascii?Q?fJptHAsa7Pt6c4HGEavEQbUwWovLvTqn07t5wdc3PytO06Yx+kq6vWjFx119?=
 =?us-ascii?Q?rwSg8vfp9Bqo+YaJ15ILrWr0Hp0PN49LmP54Jvj2JMX03RyNL7r4jFPYNvAS?=
 =?us-ascii?Q?W/YcpUraidtM5HxqIVc3oR7jHNcAxal4olQcsgyKk1l+ksvgiPE0ZK6I3Bim?=
 =?us-ascii?Q?CiSS+J0mJsH6JvHiUf+FWjqTbmCivsdAQ1NEYeT0MpvH0nDmWwAZB3osMsNL?=
 =?us-ascii?Q?c8hpTA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1071ce37-575e-411c-224b-08d9be8a98a2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2567.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 22:47:52.6271
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eMNZ21wmfxtPGEX2oZTSnXVOQqy5Hu/fisgIskxPSHKoZW7wzz+7cshxmEvrT810WkNgnG1HDMpVok8QpAUOGKWanXQOAariaE9iBywkd/k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3606
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10197 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130133
X-Proofpoint-GUID: cfzaTVi6M9Hg0vkHGfY2yoKfDNj5iKa8
X-Proofpoint-ORIG-GUID: cfzaTVi6M9Hg0vkHGfY2yoKfDNj5iKa8
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:42:55 -0600, Brijesh Singh wrote:
> The CC_ATTR_SEV_SNP can be used by the guest to query whether the SNP -
> Secure Nested Paging feature is active.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
> +
> +	/**
> +	 * @CC_ATTR_SEV_SNP: Guest SNP is active.
> +	 *
> +	 * The platform/OS is running as a guest/virtual machine and actively
> +	 * using AMD SEV-SNP features.
> +	 */
> +	CC_ATTR_SEV_SNP = 0x100,

Perhaps add a note on why this is being set to 0x100?

With that...

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>