Date:   Mon, 13 Dec 2021 18:13:32 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 04/40] x86/sev: Define the Linux specific guest
 termination reasons
Message-ID: <YbfhrBtBw6lRVPFF@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-5-brijesh.singh@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210154332.11526-5-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OozY16uU9OkwndaNYxsgb0az1X1jHfIVs0L3p6sectHvKXT5YyfSHhWUzTzD?=
 =?us-ascii?Q?/9B60EzqljtaAzh/BUF7g2kxhW3nIg2GevYD0vemfZtfZkWgjg6QSfqzzdAe?=
 =?us-ascii?Q?2a/cEF7qR0KEu5xSs7e7oTgzd9LsEgUlwRgpNxOtnT/Mrnlg7IE6e3n+JaCV?=
 =?us-ascii?Q?K93BksAm3RYan0zHpkuTvFZboewuIn2WclCEIJBfsv+ah+cP8VPtHvfVN9Zx?=
 =?us-ascii?Q?IhXP8yFB576aSKs1eW0Pe5ZWnSFRExQ7dfGBN8MKO2mQnzK8Jvn7DbW93VmU?=
 =?us-ascii?Q?Gxu4Z996Dkn+c3vj06TkGLgD8mH00ESJND9Or6Np/6yl2gqXDJAs5b+B/BHN?=
 =?us-ascii?Q?7v21bNWnvYL5SjWBVdxxXlh7y/gwaoXiLNpco0s0mI03F0fdFQra8huKE8fx?=
 =?us-ascii?Q?tyGRuKD/DJKYRyNylzM4pSpOMvM9HRerbfZc67qU60QZP+8fuPvz8doP5CGW?=
 =?us-ascii?Q?GEX4pyecfgQhSguC2xHICPrmdKH/OnKo/1qeJUsvjeNC6ZdJi+tx6eEOu4Wm?=
 =?us-ascii?Q?qQ6CltvzsU2SHwVvwRAZgvQkuzwLApOSF4Lj7EKMEydFVXrcDFaojdsTgFjD?=
 =?us-ascii?Q?wS7M4M3QjMdvuHmAebZINEm2EKSgo/0pyVyRYeQcB1rTs/VEEBtkWf9P4/oB?=
 =?us-ascii?Q?eGDqQK/Y1lVZN6tP18K9RHqtEHP9J5oebALjW3pAkZ6n3scPsPOsVXf+s/Z0?=
 =?us-ascii?Q?NQxJhfOBlxINVFAze2plVBy92h37YpSvutQAqM4AwkGt58Vn/PgbCtqAntQ/?=
 =?us-ascii?Q?VlDoToAbaSRJ67ew4+d2qpvkXpBSXdN5EbnJtSQcPCcogi7Gb4CIRkayjGl2?=
 =?us-ascii?Q?GvhVR3pX+tShguxOmzufYkd6zintxQ94ADkTEiesSZU8hzsb0z2gwBHEDGPp?=
 =?us-ascii?Q?TFszyAuQj7ZJIdUHjvpStP15au8qFHyhv3cLBvrQRhVCnOjnFMcyI74W42cl?=
 =?us-ascii?Q?fV15exnPu64w3PdAmSJuusdtl9fOEcRJ6KQEsY/zXyfH69SXQqENA1h929VP?=
 =?us-ascii?Q?lfQap9tSFBGVgJhfUNIrIFt1Xfb3gL6wVTszlhxwlFRnwls8RvABsWcPlULI?=
 =?us-ascii?Q?lKIZ5mPnSs4r9gkZpPttAlJKwgDbxKDBbc/gBrYTa9KfLbe02p59/pUF7L//?=
 =?us-ascii?Q?g+9VrGfOddhFBi2KfCOI7HjR4l3jqsJctswAK6IOnJE/CxqusoWC5Er8eKeB?=
 =?us-ascii?Q?nX+mC36cf4ztbP+ZrSd0dKx63LAXImX+Z9E/Kd8aJCm0UDsST3GguMM6hqJR?=
 =?us-ascii?Q?twkrUBADc7B5Hin0uK1aJjECvQRTHjITzWrLQbUPbq5Te2v1RUS7fOUGNuRE?=
 =?us-ascii?Q?s98XmTokAalHNAdpdN7Z3NK1lEmLr9c26CGJ99EKwZsa4rQ/Ptdr4yuDm6k5?=
 =?us-ascii?Q?C7JDoV0pwUSBipxz+QshsdqZHN89qvWZ1nkRbzbD3Z/7nofX3fDWjrQPoarw?=
 =?us-ascii?Q?p+thETgfshzvKmS8NWY6bdFIJe9vGvuaV0F+HiSN7logHZX7kocTzKWgkwkt?=
 =?us-ascii?Q?1tWSSp6pxFz84+4sM7UMbqeIcTO+xGJ/nIiJTyZ49ljziGsrBwyTaN0pkGOq?=
 =?us-ascii?Q?fDvZzUYUWPWIRmtk3+7R64Bq35XIVnkPtawykb8Q3Wx7yyyHf9S3LBVJnEFC?=
 =?us-ascii?Q?roO9a6Ns3eSWziV2Hg4qEKMClvOetImmW/OuJIgvo1gRHSXhxudWJHsYGMDt?=
 =?us-ascii?Q?prJU8Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f3f03f9-fa83-49ab-54ff-08d9be9693a1
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 00:13:38.3240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v1wa5pWuZV4DZNXphk3gQTTrYbTMAqPitT9KK9ECJxJg3DCJgXs4Xfmvbi4LdFlBs5LDVvBNfTy3RkmWEwnE11QE5YAkdpqwtFb7IUSPGmM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2574
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10197 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130142
X-Proofpoint-GUID: vim2D-70DZTnzt4l5qpCu8oxoFiG9Aay
X-Proofpoint-ORIG-GUID: vim2D-70DZTnzt4l5qpCu8oxoFiG9Aay
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:42:56 -0600, Brijesh Singh wrote:
> GHCB specification defines the reason code for reason set 0. The reason
> codes defined in the set 0 do not cover all possible causes for a guest
> to request termination.
> 
> The reason set 1 to 255 is reserved for the vendor-specific codes.

s/set 1 to 255 is/sets 1 to 255 are/

> Reseve the reason set 1 for the Linux guest. Define an error codes for

s/Define an/Define the/

> reason set 1.
> 
> While at it, change the sev_es_terminate() to accept the reason set
> parameter.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

With that...

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>

> ---
>  arch/x86/boot/compressed/sev.c    |  6 +++---
>  arch/x86/include/asm/sev-common.h |  8 ++++++++
>  arch/x86/kernel/sev-shared.c      | 11 ++++-------
>  arch/x86/kernel/sev.c             |  4 ++--
>  4 files changed, 17 insertions(+), 12 deletions(-)