From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     linux-kernel@vger.kernel.org
Cc:     Stephen Brennan <stephen.s.brennan@oracle.com>,
        Gautham Ananthakrishna <gautham.ananthakrishna@oracle.com>,
        Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
        linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/4] Fix softlockup when adding inotify watch
Date:   Mon, 13 Dec 2021 16:53:33 -0800
Message-Id: <20211214005337.161885-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xl98IE/n9RF39homeP8Itfrl5YZdM4SpqW2YhlWNqiNOnmrooUyyzZdfukmg?=
 =?us-ascii?Q?3mA2jFC3f42oco+naZG9kF/oUqWfdD7X1oTczKvfizpJZ3YmvpORYx02Re8h?=
 =?us-ascii?Q?ofrLCZoiE+WO7AKMIaG7dkvVejlZMzYL42OJbQLdyPyp9rJqy74g9gxMkzg8?=
 =?us-ascii?Q?OoRPfREje30XSzJGzGcNpV7Zbv+5nnngN0flSpwF2kt3OEwvkftYlU572OJj?=
 =?us-ascii?Q?3tJV/GF5Y86fLpGIBjMAZTORD9SeSSylQpcId1PbyCsu6M4n2egy2ELINqVa?=
 =?us-ascii?Q?qKAHaxF04Dj3VIEUuWNSDJlhrAgIODrt1a/0J4ev1exdrJTGdJjdJm3RryLs?=
 =?us-ascii?Q?3lka7n5Q6NjvaLSKvrrlH8VnkbwclkdvnwB0McX0Uz8ycOUMEp/8rHHDlXHf?=
 =?us-ascii?Q?2VCIxVNfJGKIx2qubdwVthaT5IWbz8kyN0o7bJoqsqG6eOPt5SvjIzH3rALX?=
 =?us-ascii?Q?EYxUrd0sLX920j+Y4FFsDeGtel2apP26jc1QtWcGqNx4ps56LW5J9UhveztX?=
 =?us-ascii?Q?1CPs3y18PM8cQa5pIHrQGy3LMCryZMzfTayuzPq2AX34oMSLSBLZXmZRnb3K?=
 =?us-ascii?Q?NR2okbJyaAdeqZsPD/cfycSZhYuilONQNEn/xcNw62ybCsMwwDReL6rjVKgQ?=
 =?us-ascii?Q?OWal/GcL1eq6n7YOHtuO8kvdNA8diCTksDKDR7R+tkuwSq4072KfiwTHjTki?=
 =?us-ascii?Q?lBs5VPov9y9r6Or9ShCaOvUJMAGsNL60VWK2KGl9xToFHWI9CpAayOFnAq9Z?=
 =?us-ascii?Q?lyULvYU1YL4ExLKQm3YMR43ZK25ukDCBmrH+kCgNoU/XpIpA8ZKWPDGaW+2H?=
 =?us-ascii?Q?gdpKLTZLAER69cJmtldxgc5LinQ3vhFVW9ggbuwrYjKBfcIokiMo5rslKiWz?=
 =?us-ascii?Q?XHo8IoVrVNcenX+Q0/tYNlQ+QItnn4d8nEHUtnJsKWwKoJEeXNQvO/ImE4R2?=
 =?us-ascii?Q?KNW4rjxPJZLHbn0732ty/rxHXTQQpJz4uXvYIXNyMvb4SjrximMcwWXGJEaY?=
 =?us-ascii?Q?tserch4TDWj0V77RR6rsvubIGohocwRf//8/dF6oWRnFxVdeBXH/TPU8fqEE?=
 =?us-ascii?Q?BFxGrnTo39j5Qe4g/1i2gOfirtdCsbfpWgv49Tm8tCxFKmCKuoBbYB057u1u?=
 =?us-ascii?Q?36mVysv2l4rP5VkmOUVSsNgEywNnhB/qkrNzijtUkrbH6cOh4Y9WW/YBnloA?=
 =?us-ascii?Q?yqzZuadhvx+jD1u8p0atzlTzKFpxO030kkmOVV4CM7NNI0CNq/9i1kskOQzK?=
 =?us-ascii?Q?pE0kNrQZz8gGb4wbnI8s3/1OtRwWROyDdkS8M5oXFBQ3o8m24svj1UoYZaul?=
 =?us-ascii?Q?B+VhvnAuIz3ladr7yRXEuz8OT1e8JX0CfYgIcM0V799z0m+lMicu6TfJam2U?=
 =?us-ascii?Q?otf1nAoWoWLBQy2/9ZQjE91lDhEYO+DyWLSl/RMs5I4ScysIEkoLfmo/i2r3?=
 =?us-ascii?Q?WlaSZspm+N6VU+y54Ek6G6IUoiKb1QiTjmCYFADit//+9sErZ2SYqTdMM2d9?=
 =?us-ascii?Q?+Q6uBxtw2ODspxUmlcZ0ilgcsdToVbHW8eUoOsjIZvEptCpE7KFu6EqaeSNx?=
 =?us-ascii?Q?ZFzdX31eylu/ann5xozwZ8Z8UziEj/8KLYDh8QBlkpyXwgdwsJtMITBPqoUd?=
 =?us-ascii?Q?CQDvHOp+TPWFGxbRFvczf+IMAofI9UAonKo69YHcPDddSwpp4Uw6yyqGW8zF?=
 =?us-ascii?Q?vP0RTQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2a732df-34ad-4308-9a6a-08d9be9c2b76
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 00:53:40.4410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p+UC+kkCErOXnaoLQz6CLmX3YlIGxAY8G/YQVOxd1cj7yl/5AM8sX3m16ZEJyoC2lxlrTI1rfazSjUYu0r40cp4eLINDSheKKhji9f3ieXk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3893
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10197 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112140001
X-Proofpoint-GUID: pFoibDuK9EO4Q4l1GfATl_dbFhjaDQRk
X-Proofpoint-ORIG-GUID: pFoibDuK9EO4Q4l1GfATl_dbFhjaDQRk
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When a system with large amounts of memory has several millions of 
negative dentries in a single directory, a softlockup can occur while 
adding an inotify watch:

 watchdog: BUG: soft lockup - CPU#20 stuck for 9s! [inotifywait:9528]
 CPU: 20 PID: 9528 Comm: inotifywait Kdump: loaded Not tainted 5.16.0-rc4.20211208.el8uek.rc1.x86_64 #1
 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.4.1 12/03/2020
 RIP: 0010:__fsnotify_update_child_dentry_flags+0xad/0x120
 Call Trace:
  <TASK>
  fsnotify_add_mark_locked+0x113/0x160
  inotify_new_watch+0x130/0x190
  inotify_update_watch+0x11a/0x140
  __x64_sys_inotify_add_watch+0xef/0x140
  do_syscall_64+0x3b/0x90
  entry_SYSCALL_64_after_hwframe+0x44/0xae

This patch series is a modified version of the following:
https://lore.kernel.org/linux-fsdevel/1611235185-1685-1-git-send-email-gautham.ananthakrishna@oracle.com/

The strategy employed by this series is to move negative dentries to the 
end of the d_subdirs list, and mark them with a flag as "tail negative".  
Then, readers of the d_subdirs list, which are only interested in 
positive dentries, can stop reading once they reach the first tail 
negative dentry. By applying this patch, I'm able to avoid the above 
softlockup caused by 200 million negative dentries on my test system.  
Inotify watches are set up nearly instantly.

Previously, Al expressed concern for:

1. Possible memory corruption due to use of lock_parent() in 
sweep_negative(), see patch 01 for fix.
2. The previous patch didn't catch all ways a negative dentry could 
become positive (d_add, d_instantiate_new), see patch 01.
3. The previous series contained a new negative dentry limit, which 
capped the negative dentry count at around 3 per hash bucket. I've 
dropped this patch from the series.

Patches 2-4 are unmodified from the previous posting.

Konstantin Khlebnikov (3):
  fsnotify: stop walking child dentries if remaining tail is negative
  dcache: add action D_WALK_SKIP_SIBLINGS to d_walk()
  dcache: stop walking siblings if remaining dentries all negative

Stephen Brennan (1):
  dcache: sweep cached negative dentries to the end of list of siblings

 fs/dcache.c            | 101 +++++++++++++++++++++++++++++++++++++++--
 fs/libfs.c             |   3 ++
 fs/notify/fsnotify.c   |   6 ++-
 include/linux/dcache.h |   6 +++
 4 files changed, 110 insertions(+), 6 deletions(-)

-- 
2.30.2