From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Alexander Viro <viro@zeniv.linux.org.uk>
Cc:     Stephen Brennan <stephen.s.brennan@oracle.com>,
        Gautham Ananthakrishna <gautham.ananthakrishna@oracle.com>,
        Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] dcache: stop walking siblings if remaining dentries all negative
Date:   Mon, 13 Dec 2021 16:53:37 -0800
Message-Id: <20211214005337.161885-5-stephen.s.brennan@oracle.com>
In-Reply-To: <20211214005337.161885-1-stephen.s.brennan@oracle.com>
References: <20211214005337.161885-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mYCbIzaviqapGepHfSPzTIn1RE/px0dPclaeckwDMHoPJXRQWprAnxT154n9?=
 =?us-ascii?Q?bOLHJfqf7cQQ2LltY0J57CIMngwJYGK70KRuquxgoFkMJij/MWAHApoCylHd?=
 =?us-ascii?Q?VK7ZwcsJYZT17nz2BrDAWJKS+qxw4GBSSDnQYRsCs3pejPEZj6/hDTYB8psj?=
 =?us-ascii?Q?fWTzpTIFbC4LKG7/476bwj5wRBVVfcsoV+M0iq77LMuzT4Ib4b7kgyxAoJFR?=
 =?us-ascii?Q?wOJXq7eFbVEMbRivwpAiPpdJzrB6/6i5H3ZBAmwU3wuTK+7k3mednwc9U5P4?=
 =?us-ascii?Q?+iXZ6V7FjXoYMslG/hTXPbvMqYCbWnxGWBxzUylI3y5ZrOrUwYkoomvhzXLb?=
 =?us-ascii?Q?Bb8EfwfjTiZamFNPzO0aUgrlnofQA/J/UuANZsdQ8heXhYa1azjJxKBUtBSJ?=
 =?us-ascii?Q?gVqHkfRtprGDEmo41uJlow7329qGQh+Vmb3rGVehY7S2nhPr1VqGkHBh4n0b?=
 =?us-ascii?Q?ljS3gdwh53pa53aZhc74Xj0rSMoMNEztUyOSTVRqfTd50Uvg8o8nADrmI+oi?=
 =?us-ascii?Q?SyXl1LeCgFylsT0pDZK4CLHS6W1ekgs56krCHRrIQlRhNVYK70uOt/ihWbvg?=
 =?us-ascii?Q?NME+r6jh2b773sVxRdGMbNnVlyvA3gWQLvy7seF34rMaUf67LDed0TJU/h0h?=
 =?us-ascii?Q?Ux+Ot+7Gq92biKPXSlZwVs6O9tT3ZDVunuIvA+XXcbVbXJ1kFYP32P1ZQZ85?=
 =?us-ascii?Q?Ii4SoLJdIC+q7tTyh/gAGP5f6+q5jrmpKuV3LIXdO4+OijkedjoGMDFCIFY+?=
 =?us-ascii?Q?9yxchQOhbWCUn9d65dA1tGLwp+jKbTQIqyABh6IY2KTcsuOm7+/rFEZwYiin?=
 =?us-ascii?Q?A/1E/b/7vu7WjkUx944+/D73ukppal8YLN4mkcGNuCUzJH+5UL2fIPnbzwBn?=
 =?us-ascii?Q?K3TT44zP/aPYR/vv/Ki6346O6LGy7gZpxxCNlJ2tFZyLhg8Z4zq6i7So/m05?=
 =?us-ascii?Q?ZL5LzLQ6tkHreJ9nJUKJLLhnktfzDWEJGkIDCuaM4F1V9ZadK7qxJxv42VXS?=
 =?us-ascii?Q?Q4AX/QehXCwO/eZbA+pS0iAZP7d2Lyw71AvJD7BcAvtrBpzDo2g2UH0j1DQJ?=
 =?us-ascii?Q?k6r33yQ0nMGZQrTbj+NqOHRWV8ZLdOUIJZh7znZhS6qBAlJk0OLMpSTIMT8s?=
 =?us-ascii?Q?g1t3GBqlGa79o2ut4zwg5LotvvDxQBpXrOxpAKqF5liAa4C9YdMiK7BSaJh4?=
 =?us-ascii?Q?ETrZWPnYXANKdEgiPQKxvxylqlQH1crmBeijAMzABYlxrJX++6LnVdL0XzqO?=
 =?us-ascii?Q?2DHZ01MQ2MtLEHpF9ASX6GiGbcRGz1423d7FiL2ebubYwVYy8MponfrgDK+a?=
 =?us-ascii?Q?3uekpf5ZeBdKdg4zdjJ//lNQtULy09+nrjDH106U1ACM6FNBzJgEzO3mD++V?=
 =?us-ascii?Q?o8CW1GynRsMBoXGdKHxdtwSyJxvk7qNHdorTFSFnQwLcQYEXga3hQYvzBFS9?=
 =?us-ascii?Q?EM3ux2iGM6+ZCzTtJew0Xm60NjfGPa15TMcQFYveOODfElMDKamUm8CYidEm?=
 =?us-ascii?Q?TgOf9VyWTJJTDLqurwHx3/lqdavY9I8O3nNh5REZn3tw77lIjSVB2k2z+1Xr?=
 =?us-ascii?Q?8cmaMNYc9uMd56O9KHIJrsE1zc5n6x6pXBVcDAekZWu12oXG9xmFGXgtt3Jz?=
 =?us-ascii?Q?T1ULepUbzMTJ0oNJvek1/NGZKU3L8M8VcxhQhzEg4XLECv9uHqh0skT3r+oO?=
 =?us-ascii?Q?NxB6ow=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3e9ae71-8d34-41d2-6b42-08d9be9c3168
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 00:53:50.3988
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EE6imNkkmwvrgKKAIkL6J8FAxB56J91xwIV9qlfkviRFalRfz1elE1m2SuODWHhGhV1NxGdXBdfyQ63f5yLj+PgJsBew5oDz65F3cRe09WY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3893
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10197 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112140001
X-Proofpoint-GUID: tqjzWpEJ83S9ccxRnTzL-IPdmgLOswWe
X-Proofpoint-ORIG-GUID: tqjzWpEJ83S9ccxRnTzL-IPdmgLOswWe
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

Most walkers are interested only in positive dentries.

Changes in simple_* libfs helpers are mostly cosmetic: it shouldn't cache
negative dentries unless uses d_delete other than always_delete_dentry().

Co-authored-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Co-authored-by: Gautham Ananthakrishna <gautham.ananthakrishna@oracle.com>
Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---
 fs/dcache.c | 9 +++++++++
 fs/libfs.c  | 3 +++
 2 files changed, 12 insertions(+)

diff --git a/fs/dcache.c b/fs/dcache.c
index 9083436f5dcb..85f33563936b 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1505,6 +1505,8 @@ static enum d_walk_ret path_check_mount(void *data, struct dentry *dentry)
 	struct check_mount *info = data;
 	struct path path = { .mnt = info->mnt, .dentry = dentry };
 
+	if (d_is_tail_negative(dentry))
+		return D_WALK_SKIP_SIBLINGS;
 	if (likely(!d_mountpoint(dentry)))
 		return D_WALK_CONTINUE;
 	if (__path_is_mountpoint(&path)) {
@@ -1751,6 +1753,10 @@ void shrink_dcache_for_umount(struct super_block *sb)
 static enum d_walk_ret find_submount(void *_data, struct dentry *dentry)
 {
 	struct dentry **victim = _data;
+
+	if (d_is_tail_negative(dentry))
+		return D_WALK_SKIP_SIBLINGS;
+
 	if (d_mountpoint(dentry)) {
 		__dget_dlock(dentry);
 		*victim = dentry;
@@ -3231,6 +3237,9 @@ static enum d_walk_ret d_genocide_kill(void *data, struct dentry *dentry)
 {
 	struct dentry *root = data;
 	if (dentry != root) {
+		if (d_is_tail_negative(dentry))
+			return D_WALK_SKIP_SIBLINGS;
+
 		if (d_unhashed(dentry) || !dentry->d_inode)
 			return D_WALK_SKIP;
 
diff --git a/fs/libfs.c b/fs/libfs.c
index ba7438ab9371..13cb44cf158e 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -411,6 +411,9 @@ int simple_empty(struct dentry *dentry)
 
 	spin_lock(&dentry->d_lock);
 	list_for_each_entry(child, &dentry->d_subdirs, d_child) {
+		if (d_is_tail_negative(child))
+			break;
+
 		spin_lock_nested(&child->d_lock, DENTRY_D_LOCK_NESTED);
 		if (simple_positive(child)) {
 			spin_unlock(&child->d_lock);
-- 
2.30.2