MIME-Version: 1.0
References: <1639389477-17586-1-git-send-email-yangtiezhu@loongson.cn> <1639389477-17586-2-git-send-email-yangtiezhu@loongson.cn>
In-Reply-To: <1639389477-17586-2-git-send-email-yangtiezhu@loongson.cn>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 14 Dec 2021 10:30:24 +0900
Message-ID: <CAK7LNAQNJv3Z7iM1vjc4vL=JbzBzT7GHq-p+DAkGVV+_bdvNBQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] MIPS: SGI-IP22: Remove unnecessary check of GCC option
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Jason Self <jason@bluehome.net>,
        Ryutaroh Matsumoto <ryutaroh@ict.e.titech.ac.jp>,
        Nathan Chancellor <nathan@kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 13, 2021 at 6:58 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> According to the document "Minimal requirements to compile the Kernel [1],


[1] is the kernel document, so you do not need to refer to the URL.

You can say:

 According to Documentation/process/changes.rst, ...


https://www.kernel.org/doc/html/latest is the moving target.
If you get access to this URL some years later, the min GCC
version may not be 5.1


Other than the nit,

Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


> the minimal version of GCC is 5.1, -mr10k-cache-barrier=store is supported
> with GCC 5.1 [2], so just remove the unnecessary check to fix the build
> error [3]:
>
>   arch/mips/sgi-ip22/Platform:28: *** gcc doesn't support needed option -mr10k-cache-barrier=store.  Stop.
>
> [1] https://www.kernel.org/doc/html/latest/process/changes.html
> [2] https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/MIPS-Options.html
> [3] https://github.com/ClangBuiltLinux/linux/issues/1543
>
> Reported-by: Ryutaroh Matsumoto <ryutaroh@ict.e.titech.ac.jp>
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  arch/mips/sgi-ip22/Platform | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/arch/mips/sgi-ip22/Platform b/arch/mips/sgi-ip22/Platform
> index 62fa30b..a4c46e3 100644
> --- a/arch/mips/sgi-ip22/Platform
> +++ b/arch/mips/sgi-ip22/Platform
> @@ -23,10 +23,5 @@ endif
>  # be 16kb aligned or the handling of the current variable will break.
>  # Simplified: what IP22 does at 128MB+ in ksegN, IP28 does at 512MB+ in xkphys
>  #
> -ifdef CONFIG_SGI_IP28
> -  ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
> -      $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
> -  endif
> -endif
>  cflags-$(CONFIG_SGI_IP28)      += -mr10k-cache-barrier=store -I$(srctree)/arch/mips/include/asm/mach-ip28
>  load-$(CONFIG_SGI_IP28)                += 0xa800000020004000
> --
> 2.1.0
>


-- 
Best Regards
Masahiro Yamada