Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70615C433FE for ; Tue, 14 Dec 2021 02:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243213AbhLNClS (ORCPT ); Mon, 13 Dec 2021 21:41:18 -0500 Received: from gate.crashing.org ([63.228.1.57]:47586 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbhLNClR (ORCPT ); Mon, 13 Dec 2021 21:41:17 -0500 Received: from ip6-localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1BE2ZZfk008992; Mon, 13 Dec 2021 20:35:37 -0600 Message-ID: <0888eb83c8b2bd53d4c3e2355019052d0ab40db6.camel@kernel.crashing.org> Subject: Re: [PATCH v3 2/4] usb: aspeed-vhub: fix remote wakeup failure in iKVM use case From: Benjamin Herrenschmidt To: Neal Liu , Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Cai Huoqing , Tao Ren , Julia Lawall , kernel test robot , Sasha Levin , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" Cc: BMC-SW Date: Tue, 14 Dec 2021 13:35:35 +1100 In-Reply-To: References: <20211208100545.1441397-1-neal_liu@aspeedtech.com> <20211208100545.1441397-3-neal_liu@aspeedtech.com> <391323f136e49387797d43e89b6e42cd95d916c2.camel@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-12-09 at 02:37 +0000, Neal Liu wrote: > I'm confused. Signaling Wakeup when wakeup_en is set if it has any ep > activities is not exactly what you said? > > wakeup_en is set only if host allows this device have wakeup > capability and bus being suspended. > > Normal ep activities would not write the MMIO because wakeup_en is > not set. Hrm... I didn't think wakeup_en was limited to the bus being suspended, but maybe I misremember, it's been a while. Cheers, Ben.