Subject: Re: [PATCH 1/2] dt-bindings: phy: ti,tcan104x-can: Document
 mux-states property
To:     Rob Herring <robh@kernel.org>
CC:     Wolfgang Grandegger <wg@grandegger.com>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>, <linux-can@vger.kernel.org>,
        <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20211202131002.12217-1-a-govindraju@ti.com>
 <20211202131002.12217-2-a-govindraju@ti.com>
 <Ybeq5dNYjN4GOzdV@robh.at.kernel.org>
From:   Aswath Govindraju <a-govindraju@ti.com>
Message-ID: <05d52ca2-424b-94b5-4f0c-56dbbc5a0c22@ti.com>
Date:   Tue, 14 Dec 2021 09:16:55 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <Ybeq5dNYjN4GOzdV@robh.at.kernel.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Rob,

On 14/12/21 1:49 am, Rob Herring wrote:
> On Thu, Dec 02, 2021 at 06:40:01PM +0530, Aswath Govindraju wrote:
>> On some boards, for routing CAN signals from controller to transceivers,
>> muxes might need to be set. This can be implemented using mux-states
>> property. Therefore, document the same in the respective bindings.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>>  .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> index 6107880e5246..5b2b08016635 100644
>> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> @@ -37,6 +37,18 @@ properties:
>>        max bit rate supported in bps
>>      minimum: 1
>>  
>> +  mux-states:
>> +    description:
>> +      mux controller node to route the signals from controller to
>> +      transceiver. Depending on the mux chip and the control lines
>> +      in it, the first and second parameters can be used for
>> +      representing control line and state. The number of arguments
>> +      is to be used based on '#mux-state-cells' property in the
>> +      mux-controller node. If '#mux-state-cells' is equal to
>> +      one then, then the argument to be used would be the state.
>> +      If it is set to two, then the first argument is the control
>> +      line and the second argument would be its corresponding state.
> 
> No need to redefine how a common property works here. What you do need 
> to define is how many entries and what they are for if more than 1. 
> 

Got it. So, I'll remove the common part that describes about the number
of arguments and only include what the arguments would mean given the
number of arguments


  mux-states:
    description:
      mux controller node to route the signals from controller to
      transceiver. Two arguments can be present depending on the mux
      chip. If mux-states has one argument then it represents the state.
      If there are two arguments then the first argument is the control
      line and the second argument is its corresponding state.


Thanks,
Aswath

> Rob
>