Date:   Tue, 14 Dec 2021 13:48:05 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Li Yang <leoyang.li@nxp.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Biwen Li <biwen.li@nxp.com>, Li Yang <leoyang.lil@nxp.com>
Subject: Re: [PATCH v2 6/8] arm64: dts: ls1028a-qds: move rtc node to the
 correct i2c bus
Message-ID: <20211214054805.GJ10916@dragon>
References: <20211204001718.8511-1-leoyang.li@nxp.com>
 <20211204001718.8511-7-leoyang.li@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211204001718.8511-7-leoyang.li@nxp.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Dec 03, 2021 at 06:17:16PM -0600, Li Yang wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> The i2c rtc is on i2c2 bus not i2c1 bus, so fix it in dts.
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> Signed-off-by: Li Yang <leoyang.lil@nxp.com>

Do we need a Fixes tag?

Shawn

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 00d5b81bdef3..baa1cc9b9835 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -276,11 +276,6 @@ temperature-sensor@4c {
>  				vcc-supply = <&sb_3v3>;
>  			};
>  
> -			rtc@51 {
> -				compatible = "nxp,pcf2129";
> -				reg = <0x51>;
> -			};
> -
>  			eeprom@56 {
>  				compatible = "atmel,24c512";
>  				reg = <0x56>;
> @@ -322,6 +317,15 @@ mux: mux-controller {
>  
>  };
>  
> +&i2c1 {
> +	status = "okay";
> +
> +	rtc@51 {
> +		compatible = "nxp,pcf2129";
> +		reg = <0x51>;
> +	};
> +};
> +
>  &enetc_port1 {
>  	phy-handle = <&qds_phy1>;
>  	phy-mode = "rgmii-id";
> -- 
> 2.25.1
>