From:   Leo Li <leoyang.li@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alexandru Marginean <alexandru.marginean@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Jason Liu <jason.hui.liu@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: RE: [PATCH v2 8/8] arm64: dts: ls1028a-qds: add overlays for various
 serdes protocols
Thread-Topic: [PATCH v2 8/8] arm64: dts: ls1028a-qds: add overlays for various
 serdes protocols
Thread-Index: AQHX6KRRJiIFQ0chz0mhKE+FNdjEzawxpTAAgAAN7mA=
Date:   Tue, 14 Dec 2021 08:14:44 +0000
Message-ID: <AS8PR04MB8946F30662DF917775B64DA98F759@AS8PR04MB8946.eurprd04.prod.outlook.com>
References: <20211204001718.8511-1-leoyang.li@nxp.com>
 <20211204001718.8511-9-leoyang.li@nxp.com> <20211214072139.GA13828@dragon>
In-Reply-To: <20211214072139.GA13828@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N0flee+BN0AoX5KXSxF9/rXpOGr7+g+6ia3tpLvbouz4/PiUEg2Zdafex9Po?=
 =?us-ascii?Q?/fLMF3PPPi5ndyuSixHEmjslSreCeYu5kK3VgraL0wR3itDBGgy1NixK6kGq?=
 =?us-ascii?Q?vNeaX6u0Q8BbGEsa/gX4vz4qxEMks8urgfi7UQ4YYGuVk+OAatNzx1/Fir3b?=
 =?us-ascii?Q?GMXl+2DFCL4CN7hToLYLWK+HJFWICyQVXvKg5ah/9QZAfx/GZMgUtPI+jCp9?=
 =?us-ascii?Q?z/vKqfkwmtwSpBjGSm/Ka7sJFWhM11EK5XFdHtdPLL07RdIOlsUxbFOR688a?=
 =?us-ascii?Q?T/I1kc6RTwmGV0lCuNhKJwn5hObgYhb8f7TIDY2Xll9OhSNzXG7HjCfNgsKz?=
 =?us-ascii?Q?Kqt20DL1roBlJwrVyJHMIfwNKuTPKaLNywWcVOsaVuGHcy/LjqU9KdAvrmHF?=
 =?us-ascii?Q?/9KCiynru/VMMQ2sF3kLnY4fYz6yoIE4fRqjTb6GiAUt1NgzImXg3OyESUAT?=
 =?us-ascii?Q?bCM4dHwh1/v2vupVJpp2cohH2CnXywhEjNrZ3jEgLtpG3I/Sr5PpC4Wl2afX?=
 =?us-ascii?Q?1ZBJrdqYUrogHEBwZ2ClryEEqD4MZrBIxIZiyzGosZNfzwkWBzKCZ4m0QD5w?=
 =?us-ascii?Q?Y0Jlxyi+ouD85xIwbBrSz2arTnaMNKO/prHmiRLkskqGVuZP8wP1arKsq+uz?=
 =?us-ascii?Q?ZQC5zVQi/wsMWfx4L37kEHRgGyaVfQyNTLAmaOlHHNwCXRISJ8c6DBkOBlVR?=
 =?us-ascii?Q?EsKEckIPV+Muhu/YnjZxYymZo0rD3Z5X7jhVcte1Xbcjd+dw4U9S04x2/vBe?=
 =?us-ascii?Q?6H2vYjd92yuDPEedfer40lGFrtv7fpeTm86F4NEGaAuC923laf97GHaV4pc8?=
 =?us-ascii?Q?xu7/SDxE4bV0IoMinVthihVA9ke7dyziNJELw0PGPo5TPDaqOiY1puTi5IQ/?=
 =?us-ascii?Q?JHW2TAgKY+M47uwkKT5uxcNOKGtp6udJdTSGcKaZProNTsuiElMt8IlPQvS/?=
 =?us-ascii?Q?XRnyM5/oqavzLcc2MqK+mImuz0S6krJfV3sNkBFSWVVPq5hx/ilqWZa/ahxK?=
 =?us-ascii?Q?4SgLx1F62Ypq2asbw99PR4ntjp7txSBVM3+oFefC+TzXnxeTxVHfcB0tLvZW?=
 =?us-ascii?Q?w5PGtYvLBCh9rPAgJiCDHoV7ONbA00JLS6AUTcGQnUfw0P6cwBms9fUsQ50i?=
 =?us-ascii?Q?RRu5suK3tupNMpHPGxyV9JOd7Jn6reJ19TPz4HpJgyaiH3bS7OQ0UZ5GiZTu?=
 =?us-ascii?Q?cj3sgRQ3MQhcIHn/AWuis8HxyM1xEA2+gKCnN4YWiNQSaQfFMoPGE7h8Lu2P?=
 =?us-ascii?Q?n06JwX8NfS0YmUQrji4fVTSjFCbVcMFiM3bdWtayJ3d/Pgowq6u1JJ57jDze?=
 =?us-ascii?Q?TRrNVnlFIBjyHNqGX/SsyIDZ1vNWTUh4S94linBlkYELHmdrTqgBJLfdG0XI?=
 =?us-ascii?Q?OPxJA7YM/acnFov4To++ixb/AI9eGesvY/5Bg9YncDikvcdshgUdJepEVQCf?=
 =?us-ascii?Q?Up8Vm+5KaOakdvGboKDamZs9X4sUQjOJZm+KDJuAW+sJq3GiJl2pKBhwCKyn?=
 =?us-ascii?Q?92LwpzYxwO79yiEaGw9GT+H4IlLEk+073wcRMohyGUYBmDs+Vgkv9hmX6SB9?=
 =?us-ascii?Q?49XtLoRAX0SK+GvgMx5Hwxzia0lHMxxEi4Mx0mHpuIzxhW//XBx3Bak9HZse?=
 =?us-ascii?Q?Zg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8946.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd51d104-403f-45b9-45ed-08d9bed9c991
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 08:14:44.7113
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x3lqP2oY2z2al0aZTkEL4sdlL6j7M7LeyjKiwE8DfAkeSZqRenJnsMYmVoE5Ac6Z9Ng3QPELcOykOZtjTzsQwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8644
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Tuesday, December 14, 2021 3:22 PM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> Alexandru Marginean <alexandru.marginean@nxp.com>; Ioana Ciornei
> <ioana.ciornei@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; Jason
> Liu <jason.hui.liu@nxp.com>; Vladimir Oltean <vladimir.oltean@nxp.com>
> Subject: Re: [PATCH v2 8/8] arm64: dts: ls1028a-qds: add overlays for var=
ious
> serdes protocols
>=20
> On Fri, Dec 03, 2021 at 06:17:18PM -0600, Li Yang wrote:
> > From: Alex Marginean <alexandru.marginean@nxp.com>
> >

[snip]

> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-9999.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-9999.dts
> > new file mode 100644
> > index 000000000000..1ef743c48e84
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-9999.dts
> > @@ -0,0 +1,79 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Device Tree fragment for LS1028A QDS board, serdes 85xx
> > + *
> > + * Copyright 2019-2021 NXP
> > + *
> > + * Requires a LS1028A QDS board without lane B rework.
> > + * Requires a SCH-24801 card in slot 1.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +/ {
> > +	fragment@0 {
>=20
> Is fragment0 more appropriate maybe, as @unit-address requires a
> corresponding 'reg' property?

Not sure if the overlay framework will use the index information somehow, b=
ut this is how it is demonstrated in the Documentation/devicetree/overlay-n=
otes.rst document.

Regards,
Leo