Message-ID: <3c2441ab654aae70b2d84514f98ebbcdec13fd5e.camel@pengutronix.de>
Subject: Re: [PATCH V4 2/9] soc: imx: gpcv2: Add dispmix and mipi domains to
 imx8mn
From:   Lucas Stach <l.stach@pengutronix.de>
To:     Adam Ford <aford173@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Cc:     aford@beaconembedded.com, tharvey@gateworks.com,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 14 Dec 2021 09:54:12 +0100
In-Reply-To: <20211128131853.15125-3-aford173@gmail.com>
References: <20211128131853.15125-1-aford173@gmail.com>
         <20211128131853.15125-3-aford173@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am Sonntag, dem 28.11.2021 um 07:18 -0600 schrieb Adam Ford:
> The dispmix will be needed for the blkctl driver, so add it
> to the gpcv2.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  drivers/soc/imx/gpcv2.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index a0eab9f41a71..3e59d479d001 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -843,6 +843,31 @@ static const struct imx_pgc_domain imx8mn_pgc_domains[] = {
>  		.pgc   = BIT(IMX8MN_PGC_GPUMIX),
>  		.keep_clocks = true,
>  	},
> +
> +	[IMX8MN_POWER_DOMAIN_DISPMIX] = {
> +		.genpd = {
> +			.name = "dispmix",
> +		},
> +			.bits  = {
> +			.pxx = IMX8MN_DISPMIX_SW_Pxx_REQ,
> +			.map = IMX8MN_DISPMIX_A53_DOMAIN,
> +			.hskreq = IMX8MN_DISPMIX_HSK_PWRDNREQN,
> +			.hskack = IMX8MN_DISPMIX_HSK_PWRDNACKN,
> +		},
> +		.pgc   = BIT(IMX8MN_PGC_DISPMIX),
> +		.keep_clocks = true,
> +	},
> +
> +	[IMX8MN_POWER_DOMAIN_MIPI] = {
> +		.genpd = {
> +			.name = "mipi",
> +		},
> +			.bits  = {
> +			.pxx = IMX8MN_MIPI_SW_Pxx_REQ,
> +			.map = IMX8MN_MIPI_A53_DOMAIN,
> +		},
> +		.pgc   = BIT(IMX8MN_PGC_MIPI),
> +	},
>  };
> 
>  static const struct regmap_range imx8mn_yes_ranges[] = {
> --
> 2.32.0
>