Subject: Re: [PATCH v2 1/2] nvmem: Add driver for OCOTP in Sunplus SP7021
To:     =?UTF-8?B?5pa96YyV6bS7?= <vincent.sunplus@gmail.com>
Cc:     linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        devicetree@vger.kernel.org, wells.lu@sunplus.com
References: <1638867233-8383-1-git-send-email-vincent.sunplus@gmail.com>
 <1638867233-8383-2-git-send-email-vincent.sunplus@gmail.com>
 <1b336b98-7546-93e3-f1ed-92d041c2df35@linaro.org>
 <CAPvp3RgqQ_M9rXfkWFTC5zOgk7OUGO1=o8wDjxiB+5wMPoS_Rg@mail.gmail.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <36d17f8b-2480-6c1d-fe84-d4bd04e4170f@linaro.org>
Date:   Tue, 14 Dec 2021 09:08:11 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAPvp3RgqQ_M9rXfkWFTC5zOgk7OUGO1=o8wDjxiB+5wMPoS_Rg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10/12/2021 08:50, 施錕鴻 wrote:
> 
>      > +
>      > +static const struct of_device_id sp_ocotp_dt_ids[] = {
>      > +     { .compatible = "sunplus,sp7021-ocotp", .data = &sp_otp_v0 },
>      > +     { }
>      > +};
>      > +MODULE_DEVICE_TABLE(of, sp_ocotp_dt_ids);
>      > +
>      > +static struct platform_driver sp_otp_driver = {
>      > +     .probe     = sp_ocotp_probe,
>      > +     .driver    = {
>      > +             .name           = "sunplus,sp7021-ocotp",
>      > +             .of_match_table = sp_ocotp_dt_ids,
>      > +     }
>      > +};
>      > +
>      > +static int __init sp_otp0_drv_new(void)
>      > +{
>      > +     return platform_driver_register(&sp_otp_driver);
>      > +}
>      > +subsys_initcall(sp_otp0_drv_new);
> 
>     Why this needs to be subsys_initcall() why can't it be module_init?
> 
>   The OTP driver will store the mac address for ethernet driver and usb2 
> disconnect voltage
>   for usb2 one. Therefore the order of the OTP driver should take higher 
> priority over the
> other ones.

drivers that are looking for mac address or other values from nvmem 
should get an EPROBE_DEFER if nvmem provider is not ready.

does that not work for you?


--srini