Message-ID: <2ce149d33f2e22b86d1bb1c6e114835a5e00b5d5.camel@pengutronix.de>
Subject: Re: [PATCH] irqchip/irq-imx-gpcv2: mark imx_gpcv2_instance with
 __ro_after_init
From:   Lucas Stach <l.stach@pengutronix.de>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, tglx@linutronix.de,
        maz@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com
Cc:     Peng Fan <peng.fan@nxp.com>, linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 14 Dec 2021 10:33:14 +0100
In-Reply-To: <20211214084711.1357325-1-peng.fan@oss.nxp.com>
References: <20211214084711.1357325-1-peng.fan@oss.nxp.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am Dienstag, dem 14.12.2021 um 16:47 +0800 schrieb Peng Fan (OSS):
> From: Peng Fan <peng.fan@nxp.com>
> 
> imx_gpcv2_instance will not be updated after init, so mark it with
> __ro_after_init.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  drivers/irqchip/irq-imx-gpcv2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 5b5a365dbd5e..b9c22f764b4d 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -26,7 +26,7 @@ struct gpcv2_irqchip_data {
>  	u32			cpu2wakeup;
>  };
>  
> -static struct gpcv2_irqchip_data *imx_gpcv2_instance;
> +static struct gpcv2_irqchip_data *imx_gpcv2_instance __ro_after_init;
>  
>  static void __iomem *gpcv2_idx_to_reg(struct gpcv2_irqchip_data *cd, int i)
>  {