Date:   Tue, 14 Dec 2021 10:56:05 +0100
From:   Aurelien Jarno <aurelien@aurel32.net>
To:     Palmer Dabbelt <palmer@dabbelt.com>,
        Vincent Pelletier <plr.vincent@gmail.com>
Cc:     linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive
 HiFive Unmatched
Message-ID: <YbhqNY/w36XT5zx0@aurel32.net>
Mail-Followup-To: Palmer Dabbelt <palmer@dabbelt.com>,
        Vincent Pelletier <plr.vincent@gmail.com>,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        Paul Walmsley <paul.walmsley@sifive.com>, aou@eecs.berkeley.edu,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
        "open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>
References: <20211108214629.1730870-1-aurelien@aurel32.net>
 <mhng-7ab80707-35c0-4123-8340-cf1feca4cca2@palmer-ri-x1c9>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <mhng-7ab80707-35c0-4123-8340-cf1feca4cca2@palmer-ri-x1c9>
User-Agent: Mutt/2.1.3 (2021-09-10)
Precedence: bulk

On 2021-12-13 18:13, Palmer Dabbelt wrote:
> On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:
> > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > RTC, a watchdog and the power button input.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 2e4ea84f27e7..c357b48582f7 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -70,6 +70,10 @@ pmic@58 {
> >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> >  		interrupt-controller;
> > 
> > +		onkey {
> > +			compatible = "dlg,da9063-onkey";
> > +		};
> > +
> >  		regulators {
> >  			vdd_bcore1: bcore1 {
> >  				regulator-min-microvolt = <900000>;
> > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> >  				regulator-always-on;
> >  			};
> >  		};
> > +
> > +		rtc {
> > +			compatible = "dlg,da9063-rtc";
> > +		};
> > +
> > +		wdt {
> > +			compatible = "dlg,da9063-watchdog";
> > +		};
> >  	};
> >  };

Thanks. However, wouldn't be better to merged this patch and the whole
series instead:

http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

Regards,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net