From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Marc Zyngier <maz@kernel.org>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
        Biwen Li <biwen.li@nxp.com>, "Z.Q. Hou" <zhiqiang.hou@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [RFC PATCH devicetree 00/10] Do something about ls-extirq
 interrupt-map breakage
Thread-Topic: [RFC PATCH devicetree 00/10] Do something about ls-extirq
 interrupt-map breakage
Thread-Index: AQHX8ItO3xtQxxPJV0yONti9mp5846wxrpCAgAASv4CAAAYSAIAAAr6A
Date:   Tue, 14 Dec 2021 10:30:26 +0000
Message-ID: <20211214103025.wnzkfxr5xxeuhpln@skbuf>
References: <20211214013800.2703568-1-vladimir.oltean@nxp.com>
 <87ilvrk1r0.wl-maz@kernel.org> <20211214095853.4emzycaxkuqr4tun@skbuf>
 <87czlzjxmz.wl-maz@kernel.org>
In-Reply-To: <87czlzjxmz.wl-maz@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3+58Nr/o9brmUNh4kGL5xf7U2U1WqJLZXHi4tcM6PQycl/nt6zcsQjNvcjwe?=
 =?us-ascii?Q?EZugGqZssGTtP5bu3xXTlQ1yJp0kWmwUMnz6+l2eH5pHDYDjtPTaLh+IWQ3w?=
 =?us-ascii?Q?jNK/jNyPCv5ljhOlEMQNt7Hr0X77uLQdVLKXwVP8491UeziEBAImWxdk0kUb?=
 =?us-ascii?Q?PnE3wCxfrKaRfNxWPvF8GKl82lMGOz2u16R41QAry+Nt9k4WRPfW77mqAXhA?=
 =?us-ascii?Q?sDwoyfR480nvhJsO5iPgHLO3mvVHuZn/nPU9H105N0HxIT+JOUWbwaKKK+0k?=
 =?us-ascii?Q?0nB2W0uO4YoWyz3otQGya4+8dR0eVWJtemkItBppezHDenBL0FKWdJp3lkR3?=
 =?us-ascii?Q?knPlxLj5Z4ipyv4G98uV/HJZxqzQqDmXjl7FSQqXtH+LN2qTv8qJcFKl2hW8?=
 =?us-ascii?Q?DBo16HkaT1VAxTRPzaO87prnLcmZfEf68mrFEI8Tbv93RtyZdM13ridrD8I/?=
 =?us-ascii?Q?BtPAA0H6ppmeaC5/gCezMUY8sd/r+zfRNSgPF6dw8Kbf2OdRvuSikHhIj9iW?=
 =?us-ascii?Q?UJFdiXfhZHLY9RI3ladxMJHntjdJaiNZmmZ6sms0TdQKobyAhGwsl3th34vw?=
 =?us-ascii?Q?+mXOtNDHZazgi5bJ8eGDuAVeY6O8AXV4Z+6ZS5rl2UepjfDdBFUH2VYD3/wL?=
 =?us-ascii?Q?OBAWCr+E0p0WGH+2sDB48M6hYVHgVI974ainnzwLwEaI+MYfUWOX306bRjEb?=
 =?us-ascii?Q?vpda0XqeoRyc8xU/q4K12tUQBRXXFRjrzweobvsouJ1qBMIXlpncJr4BvPJe?=
 =?us-ascii?Q?cKP/usM04ZCpktubE85GieMUdaCF/luZwshA2gcDkkKazxgfDmvWVETksMDO?=
 =?us-ascii?Q?IbiA7yZtchYg/2c2fUXnVpFVcCn1GL0glU1U/vzjl5JABqQ1mvZf/EIpMAB4?=
 =?us-ascii?Q?YUQEi+Zy++5qRBe15BgTWWhpvwfP1pT+SlMJ8FseWCzT3IcWKOWMd4Izym9C?=
 =?us-ascii?Q?VIMP8hkxIl2qS/dbroAFm5wdLGyqrYnAyyn0uk3a7hTVClHVyacC3vYfqzxv?=
 =?us-ascii?Q?FO/a5a3w03jW+QifcR1jvz2In03z8Vg60pWNfPg4FiquDskTooL5JNGBqoQw?=
 =?us-ascii?Q?C3zXW8s/0XAmKZnzODnupXX108Qq768CLqZvfYqIOOTD5qB5qmbXSSBu1LyW?=
 =?us-ascii?Q?aI94Wk1j/s2IDtcyQz1IaccnRgOeGwI+hiWv5gkAQp/wLP34MtAU8xuMeOyh?=
 =?us-ascii?Q?u3S2hUhAqNE2vEbqUFf1dH3y2uNN5BVyhbd3CHXv4yZhPQJd6Jf15cwqDTHP?=
 =?us-ascii?Q?h0boG2LWaYzisN7vMdj3lvoTF7VxDOy1wOPeEwmLaww+MvtdcWxr2jvldYxu?=
 =?us-ascii?Q?vqiD1hgtl/oxoyigHIYR3tWpR6pxvSeed2h5xICIp320jn3Jxq58frHjfCLn?=
 =?us-ascii?Q?vFM7ijoF9bFNe11XXTECsFE8A+HpTKPbdWg+MGcXM/wiP2Q+tE947/lXlFYU?=
 =?us-ascii?Q?/xhHzxccEG2CJDLXonLW5LXrPGpckwAcuK3Ka4XjxWWwA9RmvxnfDMtJVCEn?=
 =?us-ascii?Q?fldWv1GeqJ3kIHXREhSl28FSR66drmsTEad5QrnQv76DjB9l79xAFMsNz2XS?=
 =?us-ascii?Q?ozzOvT2107NB1Ye63S97/+QHpOXX2EINm8oV9DjeptKsMIucdv6HTryZobSI?=
 =?us-ascii?Q?vzDmMkdTdJxuF0chSnRR43E=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CE4DE0E467A08D4A991DF94FF2F52B2A@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9199fa3-80b5-4850-3971-08d9beecbe37
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 10:30:26.1860
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZTIrXRmx7PkYNrvrnntRUzFKzA3Z0Bls7uPa+MnlPIDFMZK8990DEbJtcGzeF9Uno2OQLY2TpWtCvxDmKZCqRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2685
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 14, 2021 at 10:20:36AM +0000, Marc Zyngier wrote:
> On Tue, 14 Dec 2021 09:58:54 +0000,
> Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> >=20
> > Hi Marc (with a c),
> >=20
> > I wish the firmware for these SoCs was smart enough to be compatible
> > with the bindings that are in the kernel and provide a blob that the
> > kernel could actually use. Some work has been started there and this is
> > work in progress. True, I don't know what other OF-based firmware some
> > other customers may use, but I trust it isn't a lot more advanced than
> > what U-Boot currently has :)
> >=20
> > Also, the machines may have been in the wild for years, but the
> > ls-extirq driver was added in November 2019. So not with the
> > introduction of the SoC device trees themselves. That isn't so long ago=
.
> >=20
> > As for compatibility between old kernel and new DT: I guess you'll hear
> > various opinions on this one.
> > https://www.spinics.net/lists/linux-mips/msg07778.html
> >=20
> > | > Are we okay with the new device tree blobs breaking the old kernel?
> > |
> > | From my point of view, newer device trees are not required to work on
> > | older kernel, this would impose an unreasonable limitation and the us=
e
> > | case is very limited.
>=20
> My views are on the opposite side. DT is an ABI, full stop. If you
> change something, you *must* guarantee forward *and* backward
> compatibility. That's because:
>=20
> - you don't control how updatable the firmware is
>=20
> - people may need to revert to other versions of the kernel because
>   the new one is broken
>=20
> - there are plenty of DT users beyond Linux, and we are not creating
>   bindings for Linux only.
>=20
> You may disagree with this, but for the subsystems I maintain, this is
> the rule I intent to stick to.

That's an honorable set of guiding principles, but how do you apply them
here? Reverting Rob's change won't fix the past, and updating the code
to account for one format will break the other. As for trying one
format, and if there's an error try the other, there may be situations
in which you accept invalid input as valid.=