Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Date:   Tue, 14 Dec 2021 10:59:10 +0000
From:   Brian Starkey <brian.starkey@arm.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     liviu.dudau@arm.com, airlied@linux.ie, daniel@ffwll.ch,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        nd@arm.com
Subject: Re: [PATCH] drm/arm/mali: potential dereference of null pointer
Message-ID: <20211214105910.zwmrgcaswgrtnb5t@000377403353>
References: <20211214100000.23395-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211214100000.23395-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: uJ5TT/YH+MAhT6wgi3w+MfxpxTh1+Q4pOILrx/BuYKfXPvzRDdk2kFeyf8a6bkK/66FknfequgBdJ7IzkXTTt3jE2fk32mwNZ3Xi8bNTRiL3l0K0/3lVbA/tK88fehADXndzRBEZKNbefGzT25lbj8HtiSiYsP2PK+3jBo4bvbNn4NS9I6n7ZvhNv4TrKWjEssxYgNQtHYtYhBCPW09nPIvcKkO18Cx+arXYXZxmFBdQjcvBhqSw5gDjx3n+Q2G4CBmqv5GBfW1q0S2MqqSEjV6JlAEO70JWC8QC0ovjzadvslz6o9JzfY63CYj+E3O15ZE1nF8BjG67hmypvEuIAlRsk1iR9QzemimBYz/WXkcHu57OvnUfqjVrspvSczhxr99sl0eMKHIe5yqkwsggXJbx840IfsajCzfXpUCNwIY1tLaQu/lPFYMsIOOon8GlGN9oEPZ8Hjx+gmdHuK9nmjT40mS/z+/6mjqXcuCQm63cQO3RRqd1nO3SbuwzK2eJp9ndKKlEmXRRuM67edkbXQkpPVyJ9yTxG0Ix68gSgubXSe3HZ6fJLldqkVTfb4NnehRTQV6CDHKCEZcwIleF+tiGQ5jG3ox5cwJs9R6mZ0OBKkjW9Gqyzh9dYI5K31gpa1FruZ6KNd+9T9Fhu2G1unMw1vPptezkgEKbyyzS4GgMWssoX6bzTwon6oGmKiqp09GR1WMrAQUL0KcX3d14Ww==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6812.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6486002)(38100700002)(6666004)(38350700002)(33716001)(86362001)(83380400001)(66556008)(66476007)(508600001)(66946007)(186003)(6916009)(316002)(2906002)(1076003)(44832011)(52116002)(6512007)(26005)(9686003)(8936002)(8676002)(5660300002)(6506007)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4028
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 6a1534bb-1364-48eb-7d06-08d9bef0c417
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QN4iyyzs8M27wQs8paIl3izo0ErDRZ4Q1RS/qB0UhCRbAsObxDlMYBugBHUyr72GClzV7U6gtCQUJaH0HqYPAKRG3s0Zn1aZjzOQ7sKF6qKd/gRhLoY2xHcdaVcNeUIKAi6GHou2SQmr3vxyJiKErYZwWIrR8Zn/PkpqCSOG+mgMXOGBx2GAne9cA0wZLm07+sv/+GX1ZRHeCPbPtbIGUxRiuuWJYXg1+X71i83iHYJxJTBRyATPl32mEfUTCW40uC/kcdPyE0Ghg2twUM1Xo8lI4D1lOiurXJVz++SAZEZ7Ea9BQelRu7x1TQMoJTJFNv2OscRqU7ohoNMOfH7BZvMCAJ2Vh/O39DQJPSbgDgqK00K60d0Y/tBEyTmhFHdLtZHuZQV/MrLI+bpeiH4dzj2X5i+sybQEYUxV8PeO7LFj4vsGQjL4jj3/75834mEa5WLDUJUH9QkxuzBXtjAQdkmCRk4XWstt8CNgL0tIKlXmhQnzOFMxfqk9shP0YtwU21Ju3yfCr15rYzQHnA3NKMJk6trEYz75cmjL1aF0MOL1sVn32072vaU9h8pef/GHWdkEKSsOAsGRKv3OzBhYJQ0iS9dFBfDclS05AHAiP4dOpcl0nkLv5mYYz83KGoOYEM5EBa6CHOIJ3pGS4rW8TwEOEDXRrtYkpWbMFy7T5J/88++5KJaTxjkFkFITRO5K1TdvIxQO9xQT6bEIHLUKY/6LjR8DI/6x/kT3BTWWHulUzJ7VqpNJ3x9pPMsxsN6s/SfSKjoVtaJQRXjZGcVQcA==
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(7916004)(4636009)(36840700001)(46966006)(40470700001)(9686003)(6512007)(6486002)(83380400001)(356005)(70206006)(36860700001)(6666004)(47076005)(81166007)(1076003)(33716001)(186003)(86362001)(6862004)(5660300002)(8676002)(70586007)(6506007)(316002)(508600001)(4326008)(8936002)(336012)(40460700001)(26005)(82310400004)(44832011)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 10:59:23.8230
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8409414b-3d67-4ded-6ea3-08d9bef0c9e5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6852
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jiasheng,

Thanks for the patch, that's a careless copy-paste on my part :-(

On Tue, Dec 14, 2021 at 06:00:00PM +0800, Jiasheng Jiang wrote:
> The return value of kzalloc() needs to be checked.
> To avoid use of null pointer '&mw_state->base' in case of the
> failure of alloc.
> 
> Fixes: 8cbc5caf36ef ("drm: mali-dp: Add writeback connector")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---

Reviewed-by: Brian Starkey <brian.starkey@arm.com>

>  drivers/gpu/drm/arm/malidp_mw.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c
> index f5847a79dd7e..612d386ee7d2 100644
> --- a/drivers/gpu/drm/arm/malidp_mw.c
> +++ b/drivers/gpu/drm/arm/malidp_mw.c
> @@ -70,7 +70,11 @@ static void malidp_mw_connector_reset(struct drm_connector *connector)
>  		__drm_atomic_helper_connector_destroy_state(connector->state);
>  
>  	kfree(connector->state);
> -	__drm_atomic_helper_connector_reset(connector, &mw_state->base);
> +
> +	if (mw_state)
> +		__drm_atomic_helper_connector_reset(connector, &mw_state->base);
> +	else
> +		__drm_atomic_helper_connector_reset(connector, NULL);
>  }
>  
>  static enum drm_connector_status
> -- 
> 2.25.1
>