Message-ID: <fef9d1be-54d5-ba1b-f7ae-fe5a063afb8f@oracle.com>
Date:   Tue, 14 Dec 2021 03:09:34 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH net] rds: memory leak in __rds_conn_create()
Content-Language: en-US
To:     Hangyu Hua <hbh25y@gmail.com>, santosh.shilimkar@oracle.com,
        davem@davemloft.net, kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
References: <20211214104659.51765-1-hbh25y@gmail.com>
From:   Sharath Srinivasan <sharath.srinivasan@oracle.com>
In-Reply-To: <20211214104659.51765-1-hbh25y@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW5ZVk5pWHV1b0NsRC9sRmdjSzRsc3haVWRMTlJBNjFaSjZzWXR5SkdqaUlE?=
 =?utf-8?B?cjNDbVhVS25WTlhTVjZZUUZwZGtYWG54R0NEbk8xdmZ3eTB0eTVPRG9YcEpS?=
 =?utf-8?B?SEtnVVB0TkJPZVFZK3ExR0piaEpkeVVWNTllNzY5K0lacmYranhQU3Y4Qnpx?=
 =?utf-8?B?NnN6NitIS3JoeXBvc3ZpVlM1NVRSS2I5eFI3cGRyVk9QM1F2QUx3L2Yzb3U5?=
 =?utf-8?B?QmV3ellYck1ZYkJVN0pldG1nVVFhV2dPSWlFVEw5eEdXc1lKV21wZUp2aW4w?=
 =?utf-8?B?N2h2TDlIWm54UCtxb0orUzd6UXhTMTVaUXRrRjBITWtQSFFPZlM4S052cE1K?=
 =?utf-8?B?Z250WXNwLzNQSlNJOEx2UzlCdmV6U2Jxc0IwS25QNVpzamUvMXdEYzlNWlha?=
 =?utf-8?B?bHZweUxBWFRBOThoY3Zjd2l5Uk9aQ1FweHpSdXE5NEdQa1J0bi8relIvYUdu?=
 =?utf-8?B?bURwdTl4ODJVYjBIU3ZROG5IUUtJbmQ4L2t5M0kzaG9kMDVxNHUrYmlWalNx?=
 =?utf-8?B?SWpiV29TWlU5OXBXNDJZRWwwYjM5MWRxYmpmWVhHY3h5ZnlYUjVNanhHRWoy?=
 =?utf-8?B?bTlQdWZNak42T041VUEwMlhtUW4yUEJWUHR4eUFGeVNKb1FWMlkvS2RmZU5y?=
 =?utf-8?B?aDROdC9jUWd0am5GTXZDUGE4SHFiWHVXVHk1MkdXRU9yeFdRQWZuUWY1VHZo?=
 =?utf-8?B?YmVNSCtpTTg0QSt5ZnZSeHBXTCtScDJtRFJhc0N6UTdZSEg0cGJMMUREQUpa?=
 =?utf-8?B?SndNbWtsQm5qanBrczViMGhDeHU1enNEc3NWMlhubWYzTDk1YmdOYjl0UTFK?=
 =?utf-8?B?VWFHZXZMYTRxYy9yQ0pqaHJ6T3ZmTmF6ckFVTmx2d1hJTW1Dc0NCeEFneXYz?=
 =?utf-8?B?V3BrSVZGTlVJRnhMazM2K0w1dXhOV1JzZ1VlU3NoL2FqVXlPQ09WQTZmL0hJ?=
 =?utf-8?B?Q28wblhZWVB3OW1wT3ZSK2h5TkpQQXZlUzc5TUhjZGpOTVN0TWdweGVrL1h0?=
 =?utf-8?B?cm9VQmFVUG5rV0QyK29xQWUwcnRtdHVBVkF4ZjJidzNLVHM3a0lnSnNIMzlX?=
 =?utf-8?B?WTNKTjV5a1JSaVJabktDd0NONzcrMHlBd3dKQ0UvYWVnNm1vNkRCby9BOElm?=
 =?utf-8?B?eENXcXFib1o3VGJoaGI2enJhdzFiR3E4bS8rZVJyc2tWdHR6bWl2Q0dQcDJw?=
 =?utf-8?B?b2J0VTNiOWFMVVRjb1F2NGNyV25PWlpXampaSzZGeCtRV0xSa2xLblRDSk13?=
 =?utf-8?B?d1Nacjl1WGpBQkhBY1ZwcGliQi9hL2sreVc2ek9uRGRpMVU4WGpBb0hvS1J0?=
 =?utf-8?B?N1hhNWlJWjJqYzUzY2g2TytUcVJCR2lXWXBFYitRUmQyaDhvSWFyTzIzOStj?=
 =?utf-8?B?TXExL2gyL3pGd0UwRFZWZ2o5TmdEK1ZFanNud2hDZTgyVWVTeis2dWtRSTlo?=
 =?utf-8?B?L25qUVRpWmZZV2lTR09aa2FnSkFlR1lVQ1ZHZHZuMDBnTnNsNXZPS2hpNzZX?=
 =?utf-8?B?WFNYVWUvaUVuNmZnU2hrNVM5S0xPdDlocDBnT0diL05XQnpsM3duL2RTbXd6?=
 =?utf-8?B?amZHdW12WEJ4bkd2eUJHL2hERlc3VEZwbXZFWWxZRFFUNDBmNjBSaldjd3dq?=
 =?utf-8?B?ZFNOVmlVQ2ZzcElmakJFZllGaGZkWVdEME1EeTQ3YTNiQm5HbStYN2Q1Mjlx?=
 =?utf-8?B?eUQ2Z0J6YnVWQXhlRzJqTGNmeEhSWFh4ckpnZU9ySzRTZ1BZNnBxREJ2NFlR?=
 =?utf-8?B?Y3FzZk9HTm1BTGpYUm9hUFdpYmlTQk5jUDB3ZmJFeTBFS1dnWFZsUnRTaWtF?=
 =?utf-8?B?N1E0dW1vTnQrNXFnaEZkQ243T2M0Y0UwNUxwdzZYc2dYZHBTZXFNVlRDVEhl?=
 =?utf-8?B?Uzh5cllIejI0TnZITUczVHpPRGIrb2FXN3gzV1kyU3BXc1BGTmZJeU5YMkdX?=
 =?utf-8?B?N1g4bFg1LytsMkZUbjZjQ1NKaHpXd2FLeWdVWXBWNkpGa2wxVXBZWW8zNlln?=
 =?utf-8?B?L0hkdkxQZnB0c0F4bm9EVFMrZW5IK1ExcGZXQmFHNDNvZ0dBQ3A0OHNjdFU2?=
 =?utf-8?B?TU9BTG5vSTYrSzJGWUVVbGtLakdzOGo0VDl4TjVMTVZuMXF0aU1CNW9kbTRx?=
 =?utf-8?B?eGtpYnFDSklqLzF1ZW5SNGhvTlQveVU4TVppL01OS2owemt2aFRIVlRobWkv?=
 =?utf-8?B?YkpudytuRnM4MUNITnpXUGVwUnIyVkJEOS9jbU1oSVlkbGR0NHlBVWRWR2Uw?=
 =?utf-8?B?UHc4TDVyRTdld2haelAvdDYzckhCVHdCTFZneDdBamQ4VktyOHBGVElsZkxF?=
 =?utf-8?Q?FQdyxg6u/OoTxSDNzZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d17ffb1-21b6-49ef-f08b-08d9bef23dda
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1001MB2409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 11:09:48.2915
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BOCknkv+MTU0OZBFkiBhKR/EirCf6zIskPwIQFFfMkQNY3qF++pmnCDSbty+sGMDM2RJgGNLgSQ73Wa8sGCvESR+4P7l6TdTXgvBeVDCtHk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2057
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10197 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140064
X-Proofpoint-ORIG-GUID: 3gebZ5GmyO1vFlWuuA5bpXijJ14XbUZ4
X-Proofpoint-GUID: 3gebZ5GmyO1vFlWuuA5bpXijJ14XbUZ4
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/14/21 02:46, Hangyu Hua wrote:

> __rds_conn_create() did not release conn->c_path when loop_trans != 0 and
> trans->t_prefer_loopback != 0 and is_outgoing == 0.

Probably a good idea to include:

Fixes: aced3ce57cd3 ("RDS tcp loopback connection can hang")

> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
With that,

Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com>

Thanks,
Sharath

> ---
>   net/rds/connection.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/net/rds/connection.c b/net/rds/connection.c
> index a3bc4b54d491..b4cc699c5fad 100644
> --- a/net/rds/connection.c
> +++ b/net/rds/connection.c
> @@ -253,6 +253,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
>   				 * should end up here, but if it
>   				 * does, reset/destroy the connection.
>   				 */
> +				kfree(conn->c_path);
>   				kmem_cache_free(rds_conn_slab, conn);
>   				conn = ERR_PTR(-EOPNOTSUPP);
>   				goto out;