Date:   Tue, 14 Dec 2021 11:16:59 +0000
From:   Vincent Pelletier <plr.vincent@gmail.com>
To:     Aurelien Jarno <aurelien@aurel32.net>
Cc:     Palmer Dabbelt <palmer@dabbelt.com>, linux-kernel@vger.kernel.org,
        robh+dt@kernel.org, Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive
 HiFive Unmatched
Message-ID: <20211214111659.29bf5ea4@gmail.com>
In-Reply-To: <YbhqNY/w36XT5zx0@aurel32.net>
References: <20211108214629.1730870-1-aurelien@aurel32.net>
        <mhng-7ab80707-35c0-4123-8340-cf1feca4cca2@palmer-ri-x1c9>
        <YbhqNY/w36XT5zx0@aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 14 Dec 2021 10:56:05 +0100, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2021-12-13 18:13, Palmer Dabbelt wrote:
> > On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:  
> > > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > > RTC, a watchdog and the power button input.
> > > 
> > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > > ---
> > >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > index 2e4ea84f27e7..c357b48582f7 100644
> > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > @@ -70,6 +70,10 @@ pmic@58 {
> > >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> > >  		interrupt-controller;
> > > 
> > > +		onkey {
> > > +			compatible = "dlg,da9063-onkey";
> > > +		};
> > > +
> > >  		regulators {
> > >  			vdd_bcore1: bcore1 {
> > >  				regulator-min-microvolt = <900000>;
> > > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> > >  				regulator-always-on;
> > >  			};
> > >  		};
> > > +
> > > +		rtc {
> > > +			compatible = "dlg,da9063-rtc";
> > > +		};
> > > +
> > > +		wdt {
> > > +			compatible = "dlg,da9063-watchdog";
> > > +		};
> > >  	};
> > >  };  
> 
> Thanks. However, wouldn't be better to merged this patch and the whole
> series instead:
> 
> http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

My apologies about this, by the way: I had prepared that patch stack
last summer and was witholding it until the IRQ-fires-only-once
situation was resolved (it does affect at least the onkey subfunction,
although in a non-obvious way when the event triggers a shutdown or a
reboot). I did not think of checking recent submissions until it was
too late.
-- 
Vincent Pelletier
GPG fingerprint 983A E8B7 3B91 1598 7A92 3845 CAC9 3691 4257 B0C1