Message-ID: <0549abbb-9e75-70e9-399b-1b3f84dc5c20@kernel.org>
Date:   Tue, 14 Dec 2021 13:24:37 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v3 RESEND 0/5] Add QCM2290 interconnect support
Content-Language: en-US
To:     Shawn Guo <shawn.guo@linaro.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211214093011.19775-1-shawn.guo@linaro.org>
From:   Georgi Djakov <djakov@kernel.org>
In-Reply-To: <20211214093011.19775-1-shawn.guo@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Shawn,

On 14.12.21 11:30, Shawn Guo wrote:
> Changes for v3 resend:
> - Rebase on linux-next

Did you try compiling it? There is one more driver where we need to
add the QoS type, otherwise I see this error:

drivers/interconnect/qcom/msm8996.c:1884:3: error: ‘const struct 
qcom_icc_desc’ has no member named ‘is_bimc_node’
  1884 |  .is_bimc_node = true,

Thanks,
Georgi

> - Drop NOC_QOS_MODE_INVALID patch which has been applied by Georgi
> - Pick up Rob's Reviewed-by on the binding patch
> 
> Changes for v3:
> - Update bindings to define child interconnect provider nodes
> 
> Changes for v2:
> - Drop unneeded include of <dt-bindings/clock/qcom,gcc-qcm2290.h> from
>    bindings.
> 
> Shawn Guo (5):
>    interconnect: icc-rpm: Define ICC device type
>    interconnect: icc-rpm: Add QNOC type QoS support
>    interconnect: icc-rpm: Support child NoC device probe
>    dt-bindings: interconnect: Add Qualcomm QCM2290 NoC support
>    interconnect: qcom: Add QCM2290 driver support
> 
>   .../bindings/interconnect/qcom,qcm2290.yaml   |  137 ++
>   drivers/interconnect/qcom/Kconfig             |    9 +
>   drivers/interconnect/qcom/Makefile            |    2 +
>   drivers/interconnect/qcom/icc-rpm.c           |   52 +-
>   drivers/interconnect/qcom/icc-rpm.h           |   14 +-
>   drivers/interconnect/qcom/msm8916.c           |    4 +-
>   drivers/interconnect/qcom/msm8939.c           |    5 +-
>   drivers/interconnect/qcom/qcm2290.c           | 1363 +++++++++++++++++
>   drivers/interconnect/qcom/sdm660.c            |    7 +-
>   .../dt-bindings/interconnect/qcom,qcm2290.h   |   94 ++
>   10 files changed, 1676 insertions(+), 11 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml
>   create mode 100644 drivers/interconnect/qcom/qcm2290.c
>   create mode 100644 include/dt-bindings/interconnect/qcom,qcm2290.h
>