From:   Qing Wang <wangqing@vivo.com>
To:     Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] drm: tegra: use vmemdup_user instead of kvmalloc and copy_from_user
Date:   Tue, 14 Dec 2021 04:18:17 -0800
Message-Id: <1639484297-75825-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jQUAKx8DzUIZGY2T+tF8TP0dJT+vXZ8Ut4YLaraFo+qrmlumQ1ToBgvg669u?=
 =?us-ascii?Q?iV3wi443xnO9g7G1pP+UmL6brX58/YEeYLTaQsxckzLeHVJ67Wl0VrNqpJlR?=
 =?us-ascii?Q?3IsTwHstDa80P0H9f6Wx9KiVfNA8p24wAx9Xepj2nkcRvl+9BZcbahyTk/6g?=
 =?us-ascii?Q?FztXu7sVgl8WRzveCqEawxzh7uHUKIuWCT+kKeaQACiw7f2kV97bcX/hH3ao?=
 =?us-ascii?Q?mMS0nB4nWaGq4E8zIGhkpi9B7wtgjJbd/iyEgUOb8gGTJV39PYl7T9YtnC+l?=
 =?us-ascii?Q?GcrdsbVcaO/Uy1aA9OBLfPqE3xDGwSxn8BBK2CWgS/RWWMT+zm8vCOdKnIpS?=
 =?us-ascii?Q?/++jpZFyNGgzOyzjUw3aoqO5Q57ya8rqslbehYDC5DiMt+KDWhxcgZVm3n1h?=
 =?us-ascii?Q?b5F8uPFTdz7RjkwGpicGPMwjJQkJZPNjW84ltvOiJRXvZM3yDqdGJB+m3kgp?=
 =?us-ascii?Q?URmJScxLSCp6b4iRfyenWdnPAwondaxqNqpIHzF2gBHQXpyXGVBp7+ArhIV+?=
 =?us-ascii?Q?AY5EFigupz2pOfF9h0oERECls1/LpxQ1iZlRbpb8GsYZrAl8AWsHOBwFBPDZ?=
 =?us-ascii?Q?GP4v+FsS3AKiayVENycn73Tg1/PqDLIWginoVa7tJ/2JLdYlUhnCmMOk9/z4?=
 =?us-ascii?Q?wt6DtPIo58vivw1z3AkMZaW62//iCBB/KT4uUMzjan4ZAMLgKdcPZPwi0quN?=
 =?us-ascii?Q?HGvg9ucypbyIIckWNPFUYXPzFCNUpwMmbzhWQV+DI+eZkdGy5L32fVGTWcSo?=
 =?us-ascii?Q?9TZk64yU0ahqJj8huA0+zcYmaBaeB/ru+Ezw5Vtv0m8qSnwiSY0YwCUz5jzd?=
 =?us-ascii?Q?xp6+iRKhqONaYKvz+qnxquhyqJ5vC/MVZRA6xEthwFTXMT7d7yCCBzdD+CPF?=
 =?us-ascii?Q?cOp3A6LbyXOR3+iVFh1edr+/oBfJu7i43CSmtkw+viDehD8aKw6zNJaIkoGg?=
 =?us-ascii?Q?zBsJ6zYqQ1fanx3oQPtmjdLtOlY8bLKP2O/tLejVWrdywKo8Mt5HsuZ4tsrO?=
 =?us-ascii?Q?jf8eROk+uFTfv8uOPfbB6GcekyatL766KYvNi+KJKBNQG0GuY7ynNz0x7mdr?=
 =?us-ascii?Q?AEumoKq+sb3LIqgh68MuKML5iaDF1EFv94znmd9Ut5dJki2s8NBOFnOdNKAl?=
 =?us-ascii?Q?8pYDzBsZji2DU+A5uefIulPY3p6PSf+mYU9K23aNOGPHKGWVAy6YVuLLT+Yx?=
 =?us-ascii?Q?OjIrUMliFRVVBGm2OG8N88Z6ABLCi9DFNtmS3Wsf1Bbz+x54j9JCFbF7bgKV?=
 =?us-ascii?Q?qfeOzlyDoarvXUbON8sk5Wnz9Pj+LSNyyDyy603MgcpZB5oJWeWgVkj6kgrc?=
 =?us-ascii?Q?/nOuVbJU5Bf0jZjC+z/EacRF/58sEDjWnYb2MEpusCDiEGYe9YNHk0NG8uPM?=
 =?us-ascii?Q?nSVHDnzPgLRuPu2DdPBgeN7QGq82gCz72ALnW37wPuR0qU2quM3BQDBFUzXV?=
 =?us-ascii?Q?EgwrdHaNrObCJipE4PHkJNqBmnqlRymHJR7zbunbZJR8bj2qIHEvlWiEOEiP?=
 =?us-ascii?Q?TFzuu8kn6jt01EsmPWtIR3xsJ5ZOKVjKWLi90tYqixzGODcksVCCm8mjVmzv?=
 =?us-ascii?Q?SAcOcnp/0sYKUEKUw2PzvIgBbLNTpkznVJOhJ5e814pxzxYGiHqqxFMmpBxF?=
 =?us-ascii?Q?8YivY02qoERldMjiJznbR38=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 845116a9-f26a-43e3-adc1-08d9befbd3ba
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 12:18:24.9850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pSwBVtAej4rmw7WJoYeywqKe+AAS1w2Nt1djhZKuAx5Mq74R5sKWY2tSIiUxyBL+Vncts1HQW5vAsRAovDHfTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR06MB3003
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

fix memdup_user.cocci warning:
gpu/drm/tegra/submit.c:172:8-16: WARNING opportunity for vmemdup_user

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/gpu/drm/tegra/submit.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
index c326984..842a2d3
--- a/drivers/gpu/drm/tegra/submit.c
+++ b/drivers/gpu/drm/tegra/submit.c
@@ -169,16 +169,7 @@ static void *alloc_copy_user_array(void __user *from, size_t count, size_t size)
 	if (copy_len > 0x4000)
 		return ERR_PTR(-E2BIG);
 
-	data = kvmalloc(copy_len, GFP_KERNEL);
-	if (!data)
-		return ERR_PTR(-ENOMEM);
-
-	if (copy_from_user(data, from, copy_len)) {
-		kvfree(data);
-		return ERR_PTR(-EFAULT);
-	}
-
-	return data;
+	return vmemdup_user(from, copy_len);
 }
 
 static int submit_copy_gather_data(struct gather_bo **pbo, struct device *dev,
-- 
2.7.4