Date:   Tue, 14 Dec 2021 13:23:55 +0100
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Philippe Schenker <philippe.schenker@toradex.com>
Cc:     netdev@vger.kernel.org, Joakim Zhang <qiangqing.zhang@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        Fugang Duan <fugang.duan@nxp.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] Add Possiblity to Reset PHY After Power-up
Message-ID: <20211214122355.GB13490@francesco-nb.int.toradex.com>
References: <20211214121638.138784-1-philippe.schenker@toradex.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211214121638.138784-1-philippe.schenker@toradex.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rHlGNuP5nmG5vlD7D/r5YFEi156aQ6HeRcey5oT+O0MzVBhf/nKVaCgKmnNc?=
 =?us-ascii?Q?wnCPHaJND5dUMJMFITld/d/NnfBP/np8GlACqQwG3jyoow+inlhVpJ1NwQEZ?=
 =?us-ascii?Q?iQ7L194myBKKf5tGE6yM8pClNpMyDkd2Nilr2HxXm7GpRngLId1olHhAu0jO?=
 =?us-ascii?Q?hMJl0z8AH35iMBOANXuoHKs0PX/01zOWXfUbh5G0tTAxZ/kCs+bKKGoE9si0?=
 =?us-ascii?Q?wh4U4zMv3V0zFjNQaLVo/jJFEREkLbA7ypum1m6kiyULQW/f9iOnr+SllmBr?=
 =?us-ascii?Q?ybQwv+J8YQ/SplfHfk/WO3rMyN6v9oVhGE2hePIl5W7JQkab2VID6Q3K/vbB?=
 =?us-ascii?Q?WzRiiYM/D8weRC2x6FM+ZGf5Bs8IZpX/a7YrLstay0e9bgUO/Q74ZQm5lNcK?=
 =?us-ascii?Q?z6gIHhZ5CBJ/h3MonXpWLsuNrxs0p7v/9Dtkr+Eo2WN19KfZEdO7rgVyi5hY?=
 =?us-ascii?Q?vHTEz1ev0OAUmAwooQM4Jf51bLWMl1JOxnxAjCo0Z7pU79TmSNzORWCq/a8G?=
 =?us-ascii?Q?/NgL1s4t2F7eaH4Z7uIHp813MV5GsFWNM9DWwK7f6XEHBF817rmJu80RP7dh?=
 =?us-ascii?Q?T8UuP+imwLNwqHnzCLx3hq3Tv73LKH6Sep5SJpk3qz6FC2SLk8RwWQPBSEe9?=
 =?us-ascii?Q?yO1FJldvjn6Ne1ImvKeejWqu/RiwCJmdfqWvc3RMytAgzXB5zAM4GFdlhhue?=
 =?us-ascii?Q?QilL75lh3ArxpWF70rW4Rl8+6gBYxIbMef5Js08iIAFC1ino7nw5x6KmTE4L?=
 =?us-ascii?Q?u2c4iNatLReveh+p8GlrP8DY/uREhAdssDuk+mqkvPWHfHsRvz9smV2cEGqA?=
 =?us-ascii?Q?GbssxvXC1OZ6Bj0bx74Gp6S4tu2iftULYHEwHo/DWHcFKIWcyFsVqrl2iTaG?=
 =?us-ascii?Q?YegVjgRjpP0OVc0KA11LGD21XE9TkXU/UdB3A1gDa3UT2UWQZTNhoNC6/go5?=
 =?us-ascii?Q?P/xCCS8fvydpJ35jAq/h/f/D1dd7xPZUdRel1SyGN//6ZTTdFV0k16AZ8vLn?=
 =?us-ascii?Q?cPVRWDldNJzxMKh4elO8Z1lgtvdK1EPgodjuKcEZys7zhull8tzst1la4iXN?=
 =?us-ascii?Q?aiH4G+sfEVL9OCeRZMfxKVUFtVfXpDp75RKuZ2LRfcmJWEIMIb8zHhOcpbW8?=
 =?us-ascii?Q?W6i6Dd0ibtebTqAENxDZEZHojKPwg1G499lhmut6xSYxDZHOCQTm+F/9DmIo?=
 =?us-ascii?Q?AJ1O7TMgpyducKv0V8hIHQvt0H9PBNaY7X63rP0bkQ0cU+wuZyvA681FSEaF?=
 =?us-ascii?Q?n739wrvysISqeSOsJNx/oBjwD3wheBqrpSKw5B5yhaA97Qfn/VbdYvpcbrg8?=
 =?us-ascii?Q?SqICUsN7pu5wwaK3vywQ0aYqYXfeC7jtPa8gE9Pr7vKX36syAxld3dOeVmz8?=
 =?us-ascii?Q?MqmeWkyrsFZw8VwNT74xEq7T2F4G+0T30umSYKruF0YQz+AaCFh5xcwe4gLX?=
 =?us-ascii?Q?N/YggcI65sEDuH56GLtopp1M/1qpwwt9UIqibaNlAxqmvTPm5g05OQmlN7sG?=
 =?us-ascii?Q?yHzxE76HsqQv5Nsre+VGAKzRGRowv41UB8wItq5FDHuqyuUZFDgjHflUPHZP?=
 =?us-ascii?Q?G1P3czzxA3VhrS6vHL5jy+G+/YeadtoM/4aMTWQJtBoepJ4Idf3OT55cqS0t?=
 =?us-ascii?Q?Qz++JEo95a7+3QR1gJZBhS1hiEz+j7hyapTid+wWCVW7cti7zxK3u485piAG?=
 =?us-ascii?Q?x3VUltHyczIm/dxmAjV9Iut/pm4=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9587441f-6571-4031-5a60-08d9befc9990
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0642.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 12:23:56.7653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t8NDBlOotVOlVnG8S7dOXXVBmP5wbCEPZyOkw8Kmgb+ekqFajHU/FigXvdsE4OMu4JXsBYytQShKJ5KkJyjPmLHwWH6rO5Q/ztKn5crec+U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZRAP278MB0061
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 14, 2021 at 01:16:35PM +0100, Philippe Schenker wrote:
> We do have a hardware design in which the ethernet phy regulator and
> reset are controlled by software. The ethernet PHY is a Microchip
> KSZ9131 [1] and the power sequencing requires a reset after the power
> goes up.
> 
> In our case the ethernet PHY is connected to a Freescale FEC and the
> driver is shutting down the regulator on suspend, however on the resume
> path the reset signal is never asserted and because of that the
> ethernet is not working anymore.
> 
> To solve this adds a new phy_reset_after_power_on() function, similar
> to the existing phy_reset_after_clk_enable(), and call it in the fec
> resume path after the regulator is switched on as suggested by
> Joakim Zhang <qiangqing.zhang@nxp.com>.
> 
> [1] https://ww1.microchip.com/downloads/en/DeviceDoc/00002841C.pdf

For the whole series.

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>