Date:   Tue, 14 Dec 2021 12:25:08 +0000
From:   Will Deacon <will@kernel.org>
To:     Bharat Bhushan <bbhushan2@marvell.com>
Cc:     mark.rutland@arm.com, robh+dt@kernel.org, bbudiredla@marvell.com,
        sgoutham@marvell.com, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/4] perf/marvell: cn10k DDR perf event core ownership
Message-ID: <20211214122507.GC14247@willie-the-truck>
References: <20211029115643.32351-1-bbhushan2@marvell.com>
 <20211029115643.32351-5-bbhushan2@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211029115643.32351-5-bbhushan2@marvell.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Oct 29, 2021 at 05:26:43PM +0530, Bharat Bhushan wrote:
> As DDR perf event counters are not per core, so they should be accessed
> only by one core at a time. Select new core when previously owning core
> is going offline.
> 
> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
> ---
> v1->v6
>  - No Change
> 
>  drivers/perf/marvell_cn10k_ddr_pmu.c | 50 ++++++++++++++++++++++++++--
>  include/linux/cpuhotplug.h           |  1 +
>  2 files changed, 49 insertions(+), 2 deletions(-)

I don't think the driver is much use without this patch, so please can you
move the Kconfig stuff to a patch at the end so that the driver can't be
enabled in a broken state half way through the series?

Will