Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720A0C433FE for ; Tue, 14 Dec 2021 12:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234037AbhLNMiq (ORCPT ); Tue, 14 Dec 2021 07:38:46 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:32918 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234015AbhLNMip (ORCPT ); Tue, 14 Dec 2021 07:38:45 -0500 Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JCybQ1qB2zcbwK; Tue, 14 Dec 2021 20:38:26 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 20:38:43 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 20:38:42 +0800 Subject: Re: [PATCH v17 05/10] x86: kdump: move reserve_crashkernel[_low]() into crash_core.c To: Baoquan He CC: Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H . Peter Anvin" , , Dave Young , Vivek Goyal , Eric Biederman , , Catalin Marinas , Will Deacon , , Rob Herring , Frank Rowand , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou References: <20211210065533.2023-1-thunder.leizhen@huawei.com> <20211210065533.2023-6-thunder.leizhen@huawei.com> <20211214104558.GA28607@MiWiFi-R3L-srv> From: "Leizhen (ThunderTown)" Message-ID: <097c6a8c-3b96-19b4-2bb9-bf2dcb4a6109@huawei.com> Date: Tue, 14 Dec 2021 20:38:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20211214104558.GA28607@MiWiFi-R3L-srv> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/12/14 18:45, Baoquan He wrote: >> + /* User specifies base address explicitly. */ > If you plan to repost, please take above sentence off either. Then we > can say this patch is only doing code moving. > >> + unsigned long long start; >> + > OK, I can see that this patch is only moving code, and introducing > CONFIG_ARCH_WANT_RESERVE_CRASH_KERNEL to wrap them appropriately, no > extra functionality change added or removed, except of this place. > An alignment checking is added for the user specified base address. > I love this checking. While I have to say it will be more perfect if > it's put in another small patch, that will be look much better from > patch splitting and reviewing point of view. Good eye. I will put it in a new patch. > > This whole patch looks great to me, thanks for the effort. > >