From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 4/9] iavf: switch to
 napi_build_skb()
Thread-Topic: [Intel-wired-lan] [PATCH net-next 4/9] iavf: switch to
 napi_build_skb()
Thread-Index: AQHX4I+ST1cKj72Da0Oqnd79bDcxXKwyENrA
Date:   Tue, 14 Dec 2021 12:50:19 +0000
Message-ID: <DM8PR11MB5621968F34C8FBCE73CD14E7AB759@DM8PR11MB5621.namprd11.prod.outlook.com>
References: <20211123171840.157471-1-alexandr.lobakin@intel.com>
 <20211123171840.157471-5-alexandr.lobakin@intel.com>
In-Reply-To: <20211123171840.157471-5-alexandr.lobakin@intel.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aZxUPrmwClwlOljPbpPqHPgNIPVN9Whv9g6nZQc6HQnErSnxgl8CSw7CuepC?=
 =?us-ascii?Q?WwwjMgxMVTLMJA8TxDj88oZGyxmuPXRDss9XbwEkcXzBhP2LzsutNRtaDuHX?=
 =?us-ascii?Q?k6kXT0UqElebqRKqeFHlR6vEQH+2Sq35XjFRbPjPAnDF0+jel3/2RXXk+FaD?=
 =?us-ascii?Q?1hUx981xy02oUdlQ8A+hpF5xcL5UzblOiCW5t0ycmMBPqSVEJXaYd1yLUM0O?=
 =?us-ascii?Q?rdtjFtBp8zTFCj/J0EiykoGo86I2bBp2b8N+nMzCwj+m4uzcidi/q6a1WV6y?=
 =?us-ascii?Q?5IVTQZfRlYPF1PnUH4eB+cHxQa4CCUib3Vl4yFp+ofgZzx0JPdfJnhrifkvZ?=
 =?us-ascii?Q?0WEPMmR10ue2m90AweOi06ZW73BaSoAYRGw7eM5kMtV3EWG/001qYEiAgHa2?=
 =?us-ascii?Q?mzfGroUM8iz3EUuCDVlf7o0P5D9iUD2acezgUu9puxOQuC+axOXjd5TTO84b?=
 =?us-ascii?Q?VXOhQhUVoiYeT+MgoTqL1GMR7SRQchSOUr+9S1JVQwqr0xib9Nmqn+lEnKd6?=
 =?us-ascii?Q?0T402q4qkAJ9YZ7ylO12pYQWnwe3Z7Zhf1YluJrNmiFpze1fsfRrC5LxdWuB?=
 =?us-ascii?Q?GdaN9UNYidMgHHGu1k95emj1IIIVxvme6gd78ykmn9iPCUHwLQXWMYr/auS+?=
 =?us-ascii?Q?rhWoyVhaZQUHOVVcE47QlXWqA2YEh1Rx3NJrSUCmzwxeHrBQLQR6T+OomUIE?=
 =?us-ascii?Q?HA596mpVe3vYsP7FuVXLa4dFvYc21lE40yjwssWV0C7sHLQrpQ/z2Q1MJEZt?=
 =?us-ascii?Q?Bibm1kYWykA5GTWqHHOhrdTzXTsLeAANFKJSxuoA53G/UdQ+d0BXRvWUconk?=
 =?us-ascii?Q?bWAvR5udHh7k2P5brFJzvGtXtscMI5RDtAJFRkRTJMMi3ybiwLW0BBgtfFqD?=
 =?us-ascii?Q?qxwTyBusXBYBpyTMGsyb3A8lhvIMQVMNf8iyLD/eS/CpFJNbY0YkdgT1rRS0?=
 =?us-ascii?Q?VFaU9hNNdGd+BYnWaKIqyr4QADSaHNwVx+qeckzK+QRqakE9kBlaoi3GTEBt?=
 =?us-ascii?Q?kbmMKAfcdGx6wIL4fmjJq2gv/yy/3fusM+XRxuogwQ6rv4B/eKkDUowDDbFV?=
 =?us-ascii?Q?00v8hmi8KBbZgz5fNdhPUgXqKHYrwRhW+eGol4Bpm3yiLHACSX+5EXf+AJnR?=
 =?us-ascii?Q?5qRQVCbKdY1y7YTAGUySH3/0eDYJYWbuQGlf5Er/kAQa1aYDMFcIGU4W2AYH?=
 =?us-ascii?Q?dalEfMFa9VgSpdI3C8/4aysP4q6JMssDuxHY7TJArMpt5eRfv5Z0vxo4EkZW?=
 =?us-ascii?Q?O0Stq1gTGgZzKRWNm3CdH06Y/S4qu7NY95QnzdrJVSLNH7ZMqzRgdcEft2go?=
 =?us-ascii?Q?ZnlwuP2GGKarLB3ZZzrepXzfYX1AKWPRbI81BOnZnxt/izz0qpK5JKPPbFBh?=
 =?us-ascii?Q?zwXbjM7yOAKFzFhLcG4wk/JNIsErjy55Ue9xXjk5JnVfF5JY0NIG0V4fyEjO?=
 =?us-ascii?Q?JbZn1VvvSb8RgFQzBy96Q833K3BixCLyrga7YU0+d8+8HaILKDoHf5O/ks5C?=
 =?us-ascii?Q?dc2K9N3GjoM1++TcChZVdnxx/QsTqTwJ5iBhDcqPD8lksFHqJ1Vrx5Ia1l7R?=
 =?us-ascii?Q?IJF9xzVoH8Yt5BqUAXUZxryPeJfhlzSCeU1fMrb/+kDWebbCVsSCFJugIaET?=
 =?us-ascii?Q?gxs9mezR6PYbaY+nQjKDFDEqSQIUiRyTWNeZIRdzVX/AoH8EOKMV3S/piYE1?=
 =?us-ascii?Q?Vz2zaQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b9714aa-d002-47a6-fab5-08d9bf0048e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:50:19.2583
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ljdgVZRlqi/71FNHppW5bM+jDW1o7T99yl5E9x5IV+QlPNxHwWw0W9b2OSZffkfLNKTSWMOKCAAakRts5e97dyplnyh93fkyiJPyxmWM7qU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5590
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: wtorek, 23 listopada 2021 18:19
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net-next 4/9] iavf: switch to
> napi_build_skb()
>=20
> napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order to save
> some cycles on freeing/allocating skbuff_heads on every new Rx or
> completed Tx.
> iavf driver runs Tx completion polling cycle right before the Rx one and =
uses
> napi_consume_skb() to feed the cache with skbuff_heads of completed
> entries, so it's never empty and always warm at that moment. Switch to th=
e
> napi_build_skb() to relax mm pressure on heavy Rx.
>=20
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> index 3525eab8e9f9..90fdd828e5d8 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_txrx.c
> @@ -1363,7 +1363,7 @@ static struct sk_buff *iavf_build_skb(struct

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>