Date:   Tue, 14 Dec 2021 15:58:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Gregory Clement <gregory.clement@bootlin.com>
Subject: Re: [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first
 parameter in orion_gpio_init()
Message-ID: <YbijFsYMshx7Sy4g@smile.fi.intel.com>
References: <20211214133243.53199-1-andriy.shevchenko@linux.intel.com>
 <YbifCSYfbKoYuzDX@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YbifCSYfbKoYuzDX@shell.armlinux.org.uk>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Dec 14, 2021 at 01:41:29PM +0000, Russell King (Oracle) wrote:
> On Tue, Dec 14, 2021 at 03:32:43PM +0200, Andy Shevchenko wrote:
> > The OF node pointer is always NULL, get rid of unused parameter in
> > orion_gpio_init(). As a side effect it will allow to switch GPIO
> > library to the fwnode API, as well as in case of resurrecting it here
> > it should be fwnode_handle anyways.
> 
> Please ensure the new code follows the existing style - especially in
> terms of wrapping. Some of us still use 80 columns as a general rule.
> Thanks.

Ah, okay, I will fix that for v2.

-- 
With Best Regards,
Andy Shevchenko