Subject: Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for
 usbhid device
To:     zhuyinbo <zhuyinbo@loongson.cn>, Oliver Neukum <oneukum@suse.com>,
        Jiri Kosina <jikos@kernel.org>, benjamin.tissoires@redhat.com,
        gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com,
        mathias.nyman@linux.intel.com, stern@rowland.harvard.edu,
        rajatja@google.com, chris.chiu@canonical.com,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1638956391-20149-1-git-send-email-zhuyinbo@loongson.cn>
 <caf93951-4c63-d0f1-e3f4-d0d49dec6a47@suse.com>
 <d2e4a97a-b89b-eaf4-5aaf-89af22227746@loongson.cn>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <654e90fb-2f04-1f87-f56c-792757e140a0@suse.com>
Date:   Tue, 14 Dec 2021 15:21:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <d2e4a97a-b89b-eaf4-5aaf-89af22227746@loongson.cn>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LtBMFOjdm8UXyIU8Olmt+iSWWAU9HN1VeOIZOOk5lKB5tANHb1F+aTIOVjlo?=
 =?us-ascii?Q?lgAP8o193cm0yRYUXdQ4rxu2S0mv4NmWe5BGS3bVKWtWAnRUpATfkf3R6T+H?=
 =?us-ascii?Q?Y9FSeD6rjYauHQCug2nzAqXoU6MsHUFugfThxonoG3WBEs1ulU0Y2zti0DfK?=
 =?us-ascii?Q?sUqefZ/u+QLPGeJGS2gfmAs9S8otFBU2zHx9rjTuWoIw4vXealkJZsOAh/vD?=
 =?us-ascii?Q?MWjmfuHwtSPqA9ZPl+Lc/lEcM8Hq5s0f9qo3E4V8VRdfa68u/sTKDcD7EsyE?=
 =?us-ascii?Q?2NGZ3wHHMPwqV23iuYIrJvaZ9x/fzIrTCMICjx8crLQim6eeonxrFJa4mhUM?=
 =?us-ascii?Q?oDaQ6Xblmv44CQiXhJy9okiN0fe1F5KX1lMbBjUhkBmeO7WMNGsbKavSsqxd?=
 =?us-ascii?Q?MA0cVJktxlnHDqbdBqK5PMwfSCwpYRBoYi8sy9VXXEYv7N9AALLVi0D8co9G?=
 =?us-ascii?Q?Jtr5rEI4fJGhmUyac8dXF9g6I9LO5xD5KA3p0ENkT+W0LUtqk1YdbMQbIdQU?=
 =?us-ascii?Q?0VSx0cI3klJ13lh6IUjUhzG3qQVzjJwDObNEMQihQ1Zn5QBG2ceovdVX84H3?=
 =?us-ascii?Q?94xsa2lxHWP2JAbIm5gaZikszuAG8k7PNKG/egTYqk5UPslUg5CuQjjIIb/z?=
 =?us-ascii?Q?+uw1jgF1IIDp/wvgrkQq7rIeY2IUpuXZ4IkDuyKJxa5ATuVM6NYlyZ8ya0sn?=
 =?us-ascii?Q?nXX2WRuUFGmXVviSn4oeR+HnKg+/LLaTgv83rhXWJ3wLBzbmKX2398cAwjBx?=
 =?us-ascii?Q?+sOsV7BKz2p3XwCsWDFZYskrc0ad4myq2EHgQFpgXl02Ys/O3Ss38UdCRbFj?=
 =?us-ascii?Q?I79h+cdFJg+QRxYVcUoxtM5M8Xqp+JrtD6hQCFZ48ShIxwbLEEunrSUDhJJF?=
 =?us-ascii?Q?C49rmA7jodvT5wBYxHsxFqTLTn8FNM4jugfS/R/hmXQyerRy1w5r1qpxCC9e?=
 =?us-ascii?Q?bKninEvLrLyzXeiPygDV5xiYeXoqmHqJPTD5IBVin7vX7QoMBpm9pk5LTsXr?=
 =?us-ascii?Q?ZtXIXOsujIyt1+pGr7aNkcW4/C6K6gTVJdszLdLA4OHSW3dHSsGAXU+BP3vt?=
 =?us-ascii?Q?9Ej/61oEr9X+y3s85hPfFxl+8+qOfaRGNOClK0L5koauxsGBrxHl/DzL7HHJ?=
 =?us-ascii?Q?aRDJ7JIBIbjQtENmv+5OtmxYC0y1EmV7SOqB/1A7sfOWP0CG+4ejXFNIPZtw?=
 =?us-ascii?Q?uU1PXyX52dVDV7btXR2VHuSmGSojeSoPweTD0qLulJh/+RpO3TerSNpGLxsb?=
 =?us-ascii?Q?gOc+RdfGTquyNdPZmfl3/D72NZ+D5EJdmTIJpMjHyK/9g1SBUo7Ikpm2uwD/?=
 =?us-ascii?Q?1vz4WjhT+16BlvHPDXkMpUhfVaGYHmvpCmMwN9BrFurRn2SQ+1lJyEp4b5Oa?=
 =?us-ascii?Q?p3AK0bm/xLhMOewddyN5ldUsnGZb47xh9vflSm4RzZpiXNUapvHOurFkflPx?=
 =?us-ascii?Q?Tm4XsNUKUKMkhU05qTD5YxGaIfJi7A3EhghmuOtlr8GFEqceeZZvw7K3caqE?=
 =?us-ascii?Q?ktHgIOLRKJeeU8STBbdZHzwnz3iJbOzuGXlmCBM+ALPlKOIywAUjbczT+5XV?=
 =?us-ascii?Q?KP4UPzhdn+iAwqLr6m+tw1Vy8PsPoau9ZTRvthI6UAwT5h5Jhj5dwiu95mZM?=
 =?us-ascii?Q?JEX8s9R8U77kqGJALBoKh87gcQC6ObSTXawETSpP7O/Y0bI35exOydADnAHP?=
 =?us-ascii?Q?osPtrenstWy2iGF8B32jVnrK94o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff4956ad-4d94-48f1-f177-08d9bf0d1310
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 14:21:52.7182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LITBIAYOd0nTPa0q7gUXj9mh0+AMcil/SypHeN6TP0QDZOLp2GzyhfMqBhsWzdQSHX2wRApIjl8RAAph8K6PQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5049
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10.12.21 10:50, zhuyinbo wrote:
Hi,
> system ask that must it must be accped a acpi lid open event then
> system will always into resume state for laptop, otherwise, eventhough
> that system be wakeuped by other event then system will continue into
> suspend.
Lid events are necesarily for the whole system.
>
> and for laptop usb wakeup that as general ask bios to enable usb
> wakeup then if need do more things to enable usb wakeup I think this
> usb wakeup function isn't friendly and inconveient, so enable it by
> default.
> after add this patch, if want to use usb wakeup function it only need
> enable bios configure it think it is appropriate.
>
No. If you wish your laptop to be resumed by USB events, that is one thing.
You can alter the system settings. That must work. But it is a different
issue

from the default.

In general any HID device must have wakeup capability to be usable for
selective suspend. You cannot draw conclusions from that.

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver