Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAMuHMdW81VE=J+ChT5jVMhHmVnMi_eQix7aXjLQPJk+qKp-EdQ@mail.gmail.com>
References: <20211130164311.2909616-1-kieran.bingham+renesas@ideasonboard.com> <20211130164311.2909616-3-kieran.bingham+renesas@ideasonboard.com> <CAMuHMdW81VE=J+ChT5jVMhHmVnMi_eQix7aXjLQPJk+qKp-EdQ@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] arm64: dts: renesas: r8a779a0: falcon-cpu: Add DSI display output
From:   Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>, open list:
        OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS 
        <devicetree@vger.kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        open list <linux-kernel@vger.kernel.org>, ;
Illegal-Object: Syntax error in Cc: address found on vger.kernel.org:
        Cc:     ;
                        ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 14 Dec 2021 14:23:39 +0000
Message-ID: <163949181978.2512616.9466994004921760294@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Geert Uytterhoeven (2021-12-14 10:49:15)
> Hi Kieran,
>=20
> On Tue, Nov 30, 2021 at 5:43 PM Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
> > Provide the display output using the sn65dsi86 MIPI DSI bridge
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>=20
> LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.17.
>=20
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
>=20
> > @@ -146,6 +190,41 @@ &i2c1 {
> >
> >         status =3D "okay";
> >         clock-frequency =3D <400000>;
> > +
> > +       sn65dsi86@2c {
> > +               compatible =3D "ti,sn65dsi86";
> > +               reg =3D <0x2c>;
> > +
> > +               clocks =3D <&sn65dsi86_refclk>;
> > +               clock-names =3D "refclk";
> > +
> > +               interrupt-parent =3D <&gpio1>;
> > +               interrupts =3D <24 IRQ_TYPE_LEVEL_HIGH>;
>=20
> Does the driver use this interrupt, and is it triggered?

No, it does not currently, but I expect it can be made to do so. Which
is likely a next development task to adapt polling hotplug to interrupt
driven hotplug detection anyway, so I'll try that then.


> If yes, as GP1_24 =3D=3D IRQ0, you can switch from a GPIO to an INTC_EX I=
RQ,
> (don't forget to configure pinctrl) and test the INTC_EX driver.
>=20
> Gr{oetje,eeting}s,
>=20
>                         Geert
>=20
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=
8k.org
>=20
> In personal conversations with technical people, I call myself a hacker. =
But
> when I'm talking to journalists I just say "programmer" or something like=
 that.
>                                 -- Linus Torvalds