From:   Rob Herring <robh@kernel.org>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     devicetree@vger.kernel.org,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Zhiqiang Hou <Zhiqiang.Hou@nxp.com>,
        Marc Zyngier <maz@kernel.org>, linux-kernel@vger.kernel.org,
        Shawn Guo <shawnguo@kernel.org>, Biwen Li <biwen.li@nxp.com>,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Li Yang <leoyang.li@nxp.com>
In-Reply-To: <20211214013800.2703568-11-vladimir.oltean@nxp.com>
References: <20211214013800.2703568-1-vladimir.oltean@nxp.com> <20211214013800.2703568-11-vladimir.oltean@nxp.com>
Subject: Re: [RFC PATCH devicetree 10/10] dt-bindings: ls-extirq: add a YAML schema for the validator
Date:   Tue, 14 Dec 2021 09:21:25 -0600
Message-Id: <1639495285.020377.3397587.nullmailer@robh.at.kernel.org>
Precedence: bulk

On Tue, 14 Dec 2021 03:38:00 +0200, Vladimir Oltean wrote:
> This is a conversion of the free-form description of the device tree
> bindings to a YAML schema. The description of fsl,extirq-map is best
> effort: it looks like the devicetree schema doesn't really like vendor
> properties getting too complicated, and puts a bunch of descriptions on
> what they can and can't describe. An array of uint32s is the best I
> could come up with. It doesn't help, either, that the
> schemas/interrupt-controller.yaml definition for interrupt-map, which
> I was planning to use as an inspiration, is "true # FIXME", all things
> which aren't valid in vendor properties.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  .../interrupt-controller/fsl,ls-extirq.txt    |  56 ---------
>  .../interrupt-controller/fsl,ls-extirq.yaml   | 110 ++++++++++++++++++
>  2 files changed, 110 insertions(+), 56 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.example.dts:34.31-32 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1413: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1567537

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.