Date:   Tue, 14 Dec 2021 16:58:47 +0100
Message-ID: <s5hpmpz9o08.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     Takashi Iwai <tiwai@suse.de>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        Joey Lee <jlee@suse.com>
Subject: Re: [PATCH] ima: Fix undefined arch_ima_get_secureboot() and co
In-Reply-To: <d99fc78005d8a245449dd6ca0158cf9e2a897465.camel@linux.ibm.com>
References: <20211213161145.3447-1-tiwai@suse.de>
        <d99fc78005d8a245449dd6ca0158cf9e2a897465.camel@linux.ibm.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 14 Dec 2021 16:31:21 +0100,
Mimi Zohar wrote:
> 
> Hi Takashi,
> 
> On Mon, 2021-12-13 at 17:11 +0100, Takashi Iwai wrote:
> > Currently arch_ima_get_secureboot() and arch_get_ima_policy() are
> > defined only when CONFIG_IMA is set, and this makes the code calling
> > those functions without CONFIG_IMA failing.  Although there is no such
> > in-tree users, but the out-of-tree users already hit it.
> > 
> > Move the declaration and the dummy definition of those functions
> > outside ifdef-CONFIG_IMA block for fixing the undefined symbols.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> Before lockdown was upstreamed, we made sure that IMA and lockdown
> could co-exist.  This patch makes the stub functions available even
> when IMA is not configured.  Do the remaining downstream patches
> require IMA to be disabled or can IMA co-exist?

I guess Joey (Cc'ed) can explain this better.  AFAIK, currently it's
used in a part of MODSIGN stuff in SUSE kernels, and it's calling
unconditionally this function for checking whether the system is with
the Secure Boot or not.


thanks,

Takashi