MIME-Version: 1.0
References: <tencent_D6BF2948237359EE0A47338567B88512D106@qq.com>
In-Reply-To: <tencent_D6BF2948237359EE0A47338567B88512D106@qq.com>
From:   Stephen Smalley <stephen.smalley.work@gmail.com>
Date:   Tue, 14 Dec 2021 11:14:10 -0500
Message-ID: <CAEjxPJ4nT3LFqNNh7PRP5DuuJeVfOh_JQiDboskbpBATgoJkOQ@mail.gmail.com>
Subject: Re: [PATCH] selinux: fix a wrong check condition of strcmp()
To:     xkernel.wang@foxmail.com
Cc:     Paul Moore <paul@paul-moore.com>,
        Eric Paris <eparis@parisplace.org>,
        SElinux list <selinux@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 14, 2021 at 4:34 AM <xkernel.wang@foxmail.com> wrote:
>
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> strcmp() will return 0 when two strings(s1, s2 for example) are equal.
> And if a negative number means s1 < s2. Here seems should use == 0 as
> the condition. Otherwise, the value of genfs->fstype can not be
> guaranteed.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

NAK. Look more closely at the code that follows, and understand that
the list is ordered to avoid needing to traverse all of it.

> ---
>  security/selinux/ss/services.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
> index 759d878..c9f6c3a 100644
> --- a/security/selinux/ss/services.c
> +++ b/security/selinux/ss/services.c
> @@ -2883,7 +2883,7 @@ static inline int __security_genfs_sid(struct selinux_policy *policy,
>
>         for (genfs = policydb->genfs; genfs; genfs = genfs->next) {
>                 cmp = strcmp(fstype, genfs->fstype);
> -               if (cmp <= 0)
> +               if (cmp == 0)
>                         break;
>         }
>
> --