Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD95C433EF for ; Tue, 14 Dec 2021 16:23:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235954AbhLNQX3 (ORCPT ); Tue, 14 Dec 2021 11:23:29 -0500 Received: from ixit.cz ([94.230.151.217]:53922 "EHLO ixit.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235873AbhLNQXF (ORCPT ); Tue, 14 Dec 2021 11:23:05 -0500 Received: from [192.168.1.138] (ip-89-176-96-70.net.upcbroadband.cz [89.176.96.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id 5B1522243C; Tue, 14 Dec 2021 17:23:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixit.cz; s=dkim; t=1639498982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZktYTD9EM17d3mZGc7bB98tBUNT5vMvozHbm6QejS+U=; b=jbjT/cxAuBYI2jZmaJLbC05eA+vLArOWkFQ2k8DA3OLQsXDyZb1+bv+6sor5Oub7PXTnYk LGsB6MEGaIzAy08N0gc6Jcoy+Wmf5LikcDkPksFo4vvOI41zGC7RBJrmiyQ7bp3Y/oge4s GIK1yKcjfvozF/oS+hLQtwx5HpCrSSs= Date: Tue, 14 Dec 2021 17:22:55 +0100 From: David Heidelberg Subject: Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers To: Rob Herring Cc: Alexandre Belloni , Caleb Connolly , devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Satya Priya , Alessandro Zummo , linux-rtc@vger.kernel.org, Bjorn Andersson Message-Id: <7I544R.923UO8WZHK48@ixit.cz> In-Reply-To: <1639437829.348405.1773613.nullmailer@robh.at.kernel.org> References: <20211213192946.111320-1-david@ixit.cz> <1639437829.348405.1773613.nullmailer@robh.at.kernel.org> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 13 2021 at 17:23:49 -0600, Rob Herring wrote: > On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote: >> Extend registers up to 2, also document their names. >> >> Also fixes warnings generated by `make >> qcom/sdm845-oneplus-fajita.dtb`: >> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: >> reg: [[24576], [24832]] is too long >> From schema: >> Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml >> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: >> 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+' >> From schema: >> Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml >> >> Signed-off-by: David Heidelberg >> --- >> .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9 >> ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for > dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1567467 > > > rtc@11d: compatible: Additional items are not allowed > ('qcom,pm8921-rtc' was unexpected) > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > rtc@11d: compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too > long > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml Would you consider safe, if I sent patch to remove redundant `qcom,pm8921-rtc` from arch/arm/boot/dts/qcom-mdm9615.dtsi? David