Date:   Tue, 14 Dec 2021 17:34:20 +0100
Message-ID: <s5hlf0n9mcz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Lucas Tanure <tanureal@opensource.cirrus.com>
Cc:     "Rafael J . Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        <alsa-devel@alsa-project.org>, <linux-acpi@vger.kernel.org>,
        <patches@opensource.cirrus.com>,
        <platform-driver-x86@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 09/10] ALSA: hda/realtek: Add support for Legion 7 16ACHg6 laptop
In-Reply-To: <20211214135959.1317949-10-tanureal@opensource.cirrus.com>
References: <20211214135959.1317949-1-tanureal@opensource.cirrus.com>
        <20211214135959.1317949-10-tanureal@opensource.cirrus.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 14 Dec 2021 14:59:58 +0100,
Lucas Tanure wrote:
> 
> Add Support for CS35L41 using the component binding
> method
> 
> Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>

Through a quick glance, the patch looks almost fine, just a few
nitpicking:

> @@ -6497,6 +6502,105 @@ static void alc287_fixup_legion_15imhg05_speakers(struct hda_codec *codec,
>  	}
>  }
>  
> +static int comp_match_dev_name(struct device *dev, void *data)
> +{
> +	if (strcmp(dev_name(dev), data) == 0)
> +		return 1;
> +
> +	return 0;

This could be a oneliner:
	return strcmp(dev_name(dev), data) == 0;


> +void comp_generic_playback_hook(struct hda_pcm_stream *hinfo, struct hda_codec *codec,
> +				struct snd_pcm_substream *sub, int action)

Missing static?

> +void alc287_legion_16achg6_playback_hook(struct hda_pcm_stream *hinfo, struct hda_codec *codec,
> +					 struct snd_pcm_substream *sub, int action)

Ditto.

> +{
> +	struct alc_spec *spec = codec->spec;
> +	unsigned int rx_slot;
> +	int i = 0;

A superfluous variable initialization.


thanks,

Takashi