From:   Santosh Shilimkar <santosh.shilimkar@oracle.com>
To:     Hangyu Hua <hbh25y@gmail.com>
CC:     "David S . Miller" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] rds: memory leak in __rds_conn_create()
Thread-Topic: [PATCH net] rds: memory leak in __rds_conn_create()
Thread-Index: AQHX8RGLrqo/nlvnAU2xcbmPLjHpsw==
Date:   Tue, 14 Dec 2021 17:39:29 +0000
Message-ID: <017A6000-BEAA-4684-9A3B-BE7FC40E1DB1@oracle.com>
References: <20211214104659.51765-1-hbh25y@gmail.com>
In-Reply-To: <20211214104659.51765-1-hbh25y@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8rDy3pfIBdnC4hh0Y54GT9NQXNBHRFf9snkLsWinqpyH+VLxePQv+12PyrWz?=
 =?us-ascii?Q?N7dhL/iErrlkr0YvSjznZ8y/4qXhvNVJC3pfdenpnnN0pzDMZuIiHvj89K2j?=
 =?us-ascii?Q?zfJA2n2nTUu4Sy45FaN6SdfdMWDFql/SfgAv4kj7b4pFhHweOlMg3LwPdCCC?=
 =?us-ascii?Q?tPH2XyNDVSbhk2tNfN6ff8uBDBcmsKJti/qp5P1fcEI9FccuPTtFp4l7QDdy?=
 =?us-ascii?Q?OtlVNwOkMUtyYNzBmb5lVJcL5aep5FdFRWsgG5RRuTGaA6lnDoIuljwZPh8l?=
 =?us-ascii?Q?n7iIZCTre44goR9N/5jE8nZMyADqQc5u5ZRkP1Wf/jhzRlViz8FlLbc19nsW?=
 =?us-ascii?Q?ON7LZmDZxo89rt7cr9m+/EZMf5r3y5FxBmEIbqsSbESkUrzwQcHLEj5sWt72?=
 =?us-ascii?Q?hEuWGFL/ffvtAs3SKR9YJOU+LYtDeDRNcMbg6f7ExjKy152Rv07Czs+A/vPF?=
 =?us-ascii?Q?I9I9sbcmn3HS1WcZmC1vHP3r/WBGLKE2rpdVN5h2fZ+f5cLsfmPsk0T6uiiW?=
 =?us-ascii?Q?eEb9T5og0wwelUbaU+Xw3BEbbAQfTuaseRROFrAIpwzcJHsNWn3DNm9cIQnc?=
 =?us-ascii?Q?TjTXTkaVULTmHm8WHEnc27KZ7vvenRYkApkJfZDa8WeokwWhQRMtzc8325LM?=
 =?us-ascii?Q?iGlXXWPMS3ZHDJ/DaVuehz3iq+qnIbpE5bGIvwTqs2sepHXDPhxdrqx3iQ3u?=
 =?us-ascii?Q?4uMbsdtQ0Y2NMNLcOzxPOcIPbmWgrjLiXsTnEa+hJQUYbLYD4BRWoAQlAKe7?=
 =?us-ascii?Q?f+4Sb81yfS/gC4897ehDl4u0zw62hbkYDj2n0Nms8wc99gGGPvFMq+ydrb2N?=
 =?us-ascii?Q?lIer0A8DjYnYJsNuz/cXVGDI905Kq1KUF62/AMVxQNw3s5L56CbaUMQo+z2B?=
 =?us-ascii?Q?kQxTrhqOx16AjriLEnER8BoWmXtrAJaJfubUiPyKhAMKF5EivGvrWnRXgPpr?=
 =?us-ascii?Q?IkwINBj7lN4zaQ1M5MTjVPPLM3/416hUyn5VLwH788zAmheGaqAm1Bkg+1HI?=
 =?us-ascii?Q?QSGa86VUK+/lQIiJht3cWglJGKxLapKKT6hlTCtMo71IAJk+X/1Zm+7dS6a3?=
 =?us-ascii?Q?MnPhda9bB+wXz0wENu8fkRadOJ88CrmjyvG3Lt2+AUK2aYkSs6W2RnqECr1A?=
 =?us-ascii?Q?uxiOGbPfMUxYFdxVcrcMyMSMEVbA0M4FDXwHEekAvaldqI5ht6j8V+Vx/ECA?=
 =?us-ascii?Q?SJ3jSTLXV1Rg9XMMTU3vLeqg+5ALiQp4OQVbu4s+VLEkP1d1Qu6YYRVni+1q?=
 =?us-ascii?Q?vtn6x1vmyWEn3JWMs+vs5zfHBtBNmNlml9yYd6QvqLqGSjKDihKcgBo7NOLh?=
 =?us-ascii?Q?027kLnJGoGGEJtON4MZqgmfwn12q2QybpYlDKaZ93dyNBnj0cmEDk550dKPu?=
 =?us-ascii?Q?ubjRaUqZCKULUJba9dCFhdPkW8VWXcai8Q5Rr8ujtValQDS4vqWKWUOXNlHp?=
 =?us-ascii?Q?P90S9reRWKX21ns9KqxqOAl3ahsD2NlOy7CtL4V15UWP0KabvvIOLQZCg4rw?=
 =?us-ascii?Q?rcKfwRJs5vIw6cFS0AdBIUooYN7+THOYqW62mfKv69q2O6e70k+ZXbHFQAIZ?=
 =?us-ascii?Q?+mjDmjV+SDdw/m8pJwDuKJFYNSF8wE2kb1NwEiLrhX38lViwjQuG0Y2Vxlhf?=
 =?us-ascii?Q?i0kBdk6IcJGFrskbnpwtCwaYTIutzLroBQVu0QAOWI9tzNV7QrQ7Izer/zAa?=
 =?us-ascii?Q?8/4BHNFgIAXyNxxzM9RzrWNm/Us=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DF7AB20FE8934F42B404D7D6A3B99E08@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3270.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e870c76-87ec-4d7d-d5b9-08d9bf28ae80
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 17:39:29.5505
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /XWuGuG0hNd4TKcRShUx/FfmUOvf4WCNnh9MmOnbNqa/n7kgL3eZOdN9eFuTBBCnnBD0eRW+xR4PCL9wnRz15QxS6anOCdqVcUmP/vZLTk4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2712
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10198 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140096
X-Proofpoint-GUID: J-PotTFzge70GfyWXKD2vLeVZIy5Z9YX
X-Proofpoint-ORIG-GUID: J-PotTFzge70GfyWXKD2vLeVZIy5Z9YX
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Dec 14, 2021, at 2:46 AM, Hangyu Hua <hbh25y@gmail.com> wrote:
>=20
> __rds_conn_create() did not release conn->c_path when loop_trans !=3D 0 a=
nd
> trans->t_prefer_loopback !=3D 0 and is_outgoing =3D=3D 0.
>=20
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
> net/rds/connection.c | 1 +
> 1 file changed, 1 insertion(+)

Looks good to me. Thanks !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>