From:   Andrew Kilroy <andrew.kilroy@arm.com>
To:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        acme@kernel.org
Cc:     Andrew Kilroy <andrew.kilroy@arm.com>,
        John Garry <john.garry@huawei.com>,
        Will Deacon <will@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/1] topdown with metrics
Date:   Tue, 14 Dec 2021 18:42:39 +0000
Message-Id: <20211214184240.24215-1-andrew.kilroy@arm.com>
In-Reply-To: <4c375d34-bf20-496d-22fc-aed8597126e2@huawei.com>
References: <4c375d34-bf20-496d-22fc-aed8597126e2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi John,

> BTW, I was looking at adding perf tool --topdown support for arm64. This will require L1 metricgroup support per core - see what I did here for our hisilicon platform already:
> 
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
> 
> I would like to add support for more cores. Generally the arm common events match up to the definitions here:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/Documentation/perf-stat.txt#n400
> 
> Apart from frontend_bound - would you have an equivalent metric expression for this for these Neoverse cores?
> 
> [0] Note that I think that the divisor in the metric expressions is max uops that the core can deal with. 

Thanks for this, we’ve been working on how to support perf --topdown.
We’re still considering the right events/calculations on our CPUs.

To introduce the calculations in metrics jsons we would like this patch
to alter the --topdown option on arm64.

How does this fit with your solution?

Andrew


Andrew Kilroy (1):
  perf arm64: Implement --topdown with metrics

 tools/perf/arch/arm64/util/Build     |  1 +
 tools/perf/arch/arm64/util/topdown.c |  8 ++++++++
 tools/perf/builtin-stat.c            | 13 +++++++++++++
 tools/perf/util/metricgroup.c        | 12 ++++++++++++
 tools/perf/util/metricgroup.h        |  7 +++++++
 tools/perf/util/topdown.c            |  6 ++++++
 tools/perf/util/topdown.h            |  1 +
 7 files changed, 48 insertions(+)
 create mode 100644 tools/perf/arch/arm64/util/topdown.c

-- 
2.17.1