Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F99AC433EF for ; Tue, 14 Dec 2021 18:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbhLNS7K (ORCPT ); Tue, 14 Dec 2021 13:59:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237205AbhLNS7J (ORCPT ); Tue, 14 Dec 2021 13:59:09 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 911C6C06173E for ; Tue, 14 Dec 2021 10:59:09 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id 8so18628419pfo.4 for ; Tue, 14 Dec 2021 10:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2pJn0DfJU16peOh34ZMJkbpyM+0B2Bhu8Trn1zH9ebk=; b=hZcka+a/z2kVd/raHjcI+yKiD/3iSxfU57CSOjuWwU2LFFUcq0OVkXzlC0Up+bQ55R dKnen7/tVPYa7aW3v0JnkDNtDIRMMx98vvTgj8RparkZEyTz+nrcuC6zpJe3NSYKG5Ns qwMo5WY57kYdk4gJl6zALUUy14Ugt4YwhB6xBFqsUYyFI8P9zPe1hYJw2Lckq0wjU53L FiO2BFd3ix3wgGoyii9f4NjMEGrGgr0r2p4/ivf36Sbsv+hCM6Qct9CsNUbi/mGWfA1H /muhZCDDW1JuDLWfvQ7/RQTVHuZ8RaBP9vus3wot908EBdqi0iWJXd776r/HpPptjKTG WWXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2pJn0DfJU16peOh34ZMJkbpyM+0B2Bhu8Trn1zH9ebk=; b=F4kEuZgLlG1Rm2nDZc5i/UTQTVGu7ac/GWqQ+66QPrrvdQ+4Co5wL9ekxyz4R6FEKp NHCFihUNfabeM+YJPltvNVDN4N6OXcsS3oGlHg3K55hLpZGVDbKz8/+aV9j6HoBkcSvY ZmUB1G0ZoggyB9G1PXx2kFKkKMLvp50XwsTXhCWsf9MStE6Tv8JM+t2qH/G4F2Y4lwr3 9NHZYSHJqzPVWaVxOdvuEpBUuVooFJRglHJtJgG6ksAJJVhquSuOr6qKfqvUQyLKsCkQ pMfcm1kRLuPnFDk6FJzdhSlVn56rGyALbaSrjbX8mefxKcFP74AITb4P9rjJmvP1qFll SG3w== X-Gm-Message-State: AOAM530s5YpfPi9AsAvXTbj1BmEMR1FNQ9t5G1kDCnN1C5iWBoFGqmDP UURYYZ2SDc6HywGP6yNXYMLlDg== X-Google-Smtp-Source: ABdhPJzzFcBWligXoCLNbgLyidgfA/ogRQjMhj8JkwTwzFp9582W9LNiU2LYbDKs7gVsy4buG1jzKw== X-Received: by 2002:aa7:91c3:0:b0:4b0:eebe:49c0 with SMTP id z3-20020aa791c3000000b004b0eebe49c0mr5711259pfa.6.1639508348966; Tue, 14 Dec 2021 10:59:08 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id o124sm541688pfb.177.2021.12.14.10.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Dec 2021 10:59:08 -0800 (PST) Date: Tue, 14 Dec 2021 18:59:05 +0000 From: Sean Christopherson To: Andrew Jones Cc: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, vkuznets@redhat.com, mlevitsk@redhat.com, joao.m.martins@oracle.com, stable@vger.kernel.org, David Matlack Subject: Re: [PATCH v3] selftests: KVM: avoid failures due to reserved HyperTransport region Message-ID: References: <20211209223040.304355-1-pbonzini@redhat.com> <20211214150747.c5xcdjghenunyw5e@gator.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211214150747.c5xcdjghenunyw5e@gator.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 14, 2021, Andrew Jones wrote: > (Maybe we should stop keeping the vm struct private...) I'm all in favor of that. Ditto for the vcpu struct so that we can get rid of the stupid VCPU_ID code. I have spent more time than I care to admit trying to do relatively simple things in the selftests that become unnecessarily complex just because core state like the vm_fd is hidden from individual tests.