MIME-Version: 1.0
References: <20211214192612.134306-1-dlatypov@google.com> <20211214192612.134306-2-dlatypov@google.com>
In-Reply-To: <20211214192612.134306-2-dlatypov@google.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Tue, 14 Dec 2021 16:44:29 -0500
Message-ID: <CAFd5g44qB7emcsV_QCtddUcFdoxVUpzoY_fgmRARfDwS3byNMA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] kunit: tool: delete kunit_parser.TestResult type
To:     Daniel Latypov <dlatypov@google.com>
Cc:     davidgow@google.com, linux-kernel@vger.kernel.org,
        kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
        skhan@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 14, 2021 at 2:26 PM Daniel Latypov <dlatypov@google.com> wrote:
>
> The `log` field is unused, and the `status` field is accessible via
> `test.status`.
>
> So it's simpler to just return the main `Test` object directly.
>
> And since we're no longer returning a namedtuple, which has no type
> annotations, this hopefully means typecheckers are better equipped to
> find any errors.
>
> Signed-off-by: Daniel Latypov <dlatypov@google.com>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

Looks good. Thanks for the rebase!