Date:   Tue, 14 Dec 2021 14:56:16 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     dwarves@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        bpf@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Jan Engelhardt <jengelh@inai.de>,
        Domenico Andreoli <domenico.andreoli@linux.com>,
        Matthias Schwarzott <zzam@gentoo.org>,
        Yonghong Song <yhs@fb.com>,
        Douglas RAILLARD <douglas.raillard@arm.com>,
        Ilya Leoshkevich <iii@linux.ibm.com>,
        Matteo Croce <mcroce@microsoft.com>
Subject: Re: ANNOUNCE: pahole v1.23 (BTF tags and alignment inference)
Message-ID: <YbkTAPn3EEu6BUYR@archlinux-ax161>
References: <YSQSZQnnlIWAQ06v@kernel.org>
 <YbC5MC+h+PkDZten@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YbC5MC+h+PkDZten@kernel.org>
Precedence: bulk

Hi Arnaldo,

On Wed, Dec 08, 2021 at 10:54:56AM -0300, Arnaldo Carvalho de Melo wrote:
> - Initial support for DW_TAG_skeleton_unit, so far just suggest looking up a
>   matching .dwo file to be used instead. Automagically doing this is in the
>   plans for a future release.

This change [1] appears to break building on older distributions for me,
which I use in containers for access to older versions of GCC. I see the
error with Debian Stretch and Ubuntu Xenial, which have an older
libelf-dev.  Is this expected? I don't mind sticking with 1.22 for
those, I just want to be sure!

/tmp/dwarves-1.23/dwarf_loader.c: In function 'die__process':
/tmp/dwarves-1.23/dwarf_loader.c:2529:13: error: 'DW_TAG_skeleton_unit' undeclared (first use in this function)
  if (tag == DW_TAG_skeleton_unit) {
             ^

[1]: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=0135ccd632796ab3aff65b7c99b374c4682c2bcf

Cheers,
Nathan