MIME-Version: 1.0
References: <20211213204441.56204-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20211213204441.56204-1-andriy.shevchenko@linux.intel.com>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Tue, 14 Dec 2021 16:56:21 -0500
Message-ID: <CAFd5g47FXzwtnxOH_Qc3VsWnS2RBNEreVAepWPizboZTo4KRfw@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] kunit: Replace kernel.h with the necessary inclusions
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 13, 2021 at 3:44 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>

> ---
> Andrew, please take it through your tree since KUnit maintainer is non-responsive
> by unknown (to me) reasons.

Sorry, I did not see the previous version of this patch. But this
looks fine, and does not appear to break any tests.