Date:   Wed, 15 Dec 2021 08:17:08 +0800
From:   Shawn Guo <shawn.guo@linaro.org>
To:     Georgi Djakov <djakov@kernel.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND 0/5] Add QCM2290 interconnect support
Message-ID: <20211215001707.GA15936@dragon>
References: <20211214093011.19775-1-shawn.guo@linaro.org>
 <0549abbb-9e75-70e9-399b-1b3f84dc5c20@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0549abbb-9e75-70e9-399b-1b3f84dc5c20@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Dec 14, 2021 at 01:24:37PM +0200, Georgi Djakov wrote:
> Hi Shawn,
> 
> On 14.12.21 11:30, Shawn Guo wrote:
> > Changes for v3 resend:
> > - Rebase on linux-next
> 
> Did you try compiling it? There is one more driver where we need to
> add the QoS type, otherwise I see this error:
> 
> drivers/interconnect/qcom/msm8996.c:1884:3: error: ‘const struct
> qcom_icc_desc’ has no member named ‘is_bimc_node’
>  1884 |  .is_bimc_node = true,

Oops! I did compile, but just noticed that INTERCONNECT_QCOM_MSM8996 was
not enabled in my defconfig.  I will fix it with v4.  Sorry about that,
and thanks for spotting the error, Georgi!

Shawn