Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964785AbXAXXcx (ORCPT ); Wed, 24 Jan 2007 18:32:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964786AbXAXXcx (ORCPT ); Wed, 24 Jan 2007 18:32:53 -0500 Received: from 67.111.72.3.ptr.us.xo.net ([67.111.72.3]:11405 "EHLO nonameb.ptu.promise.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964785AbXAXXcw convert rfc822-to-8bit (ORCPT ); Wed, 24 Jan 2007 18:32:52 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.0.6487.1 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [patch] scsi: use lock per host instead of per device for shared queue tag host Date: Wed, 24 Jan 2007 15:33:57 -0800 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [patch] scsi: use lock per host instead of per device for shared queue tag host Thread-Index: Acc/0NITAs4XtQHaRmmJlX3mWPtIrwAO+99Q From: "Ed Lin" To: "Michael Reed" Cc: "linux-scsi" , "linux-kernel" , "james.Bottomley" , "jeff" , "Promise_Linux" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 38 > -----Original Message----- > From: Michael Reed [mailto:mdr@sgi.com] > Sent: Wednesday, January 24, 2007 7:59 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; Promise_Linux > Subject: Re: [patch] scsi: use lock per host instead of per > device for shared queue tag host > > > How 'bout a comment in scsh_host.h indicating that the > pointer will be NULL unless > initialized by the driver? > > "Protect shared block queue tag" is unique to stex. Perhaps > have no comment on > the variable declaration in scsi_host.h and explain why you > use it in stex. > > Mike > > Thanks for commenting. I agree more detailed explaination should be better. It seems another driver(qla4xxx) is also using shared queue tag. It is natural to imagine there might be same symptom in that driver. But I don't know the driver and have no hardware so I can not say anything certain about it. Ed Lin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/