IronPort-SDR: y9Y4djH2ydE9Zo1JtGq0TLNEN86meSkWNXPAiikKhfyc87YJsOZnm7Ho4UDcliWxg1tiT9eC8U
 VHknRg0fuUcTiswS9/EjKviSvaZ6Hc/bo8/geatjGl0Jk1PJpHsiiAoj7RXqWS1ZJpGKwBFLrU
 WegXkMzbkpYmitIfAE6FrsiCb3WUMJtJq63fO9q4mNmZSYU/5ivEsr90riX0aeMAeWgV/b+jJo
 mL6nnJ5nCY8urQ/iC6mwhK/ErJMkDHDF487m4yxjjqX3V+vJ3VP7tbuzpKLMLRWRyz3p2daX7t
 NouAZRvv8iTghRTpSJSrvHme
From:   Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
To:     tglx@linutronix.de
Cc:     hch@lst.de, kbusch@kernel.org, linux-kernel@vger.kernel.org,
        maz@kernel.org, ming.lei@redhat.com, yamamoto.rei@jp.fujitsu.com
Subject: Re: [PATCH] irq: consider cpus on nodes are unbalanced
Date:   Wed, 15 Dec 2021 10:57:11 +0900
Message-Id: <20211215015711.28188-1-yamamoto.rei@jp.fujitsu.com>
In-Reply-To: <878rxdl55u.ffs@tglx>
References: <878rxdl55u.ffs@tglx>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, Nov 24 2021 at 20:33, Thomas Gleixner wrote:
> Cc'ing a few people who worked on this code.
>
>> If cpus on a node are offline at boot time, there are
>> difference in the number of nodes between when building affinity
>> masks for present cpus and when building affinity masks for possible
>> cpus. This patch fixes 2 problems caused by the difference of the
>> number of nodes:
>>
>>  - If some unused vectors remain after building masks for present cpus,
>>    remained vectors are assigned for building masks for possible cpus.
>>    Therefore "numvecs <= nodes" condition must be
>>    "vecs_to_assign <= nodes_to_assign". Fix this problem by making this
>>    condition appropriate.
>>
>>  - The routine of "numvecs <= nodes" condition can overwrite bits of
>>    masks for present cpus in building masks for possible cpus. Fix this
>>    problem by making CPU bits, which is not target, not changing.
>>
>> Signed-off-by: Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
>> ---
>>  kernel/irq/affinity.c | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
>> index f7ff8919dc9b..1cdf89e5e2fb 100644
>> --- a/kernel/irq/affinity.c
>> +++ b/kernel/irq/affinity.c
>> @@ -267,10 +267,16 @@ static int __irq_build_affinity_masks(unsigned int startvec,
>>  	 * If the number of nodes in the mask is greater than or equal the
>>  	 * number of vectors we just spread the vectors across the nodes.
>>  	 */
>> -	if (numvecs <= nodes) {
>> +	if (numvecs - (curvec - firstvec) <= nodes) {
>>  		for_each_node_mask(n, nodemsk) {
>> +			unsigned int ncpus;
>> +
>> +			cpumask_and(nmsk, cpu_mask, node_to_cpumask[n]);
>> +			ncpus = cpumask_weight(nmsk);
>> +			if (!ncpus)
>> +				continue;
>>  			cpumask_or(&masks[curvec].mask, &masks[curvec].mask,
>> -				   node_to_cpumask[n]);
>> +				   nmsk);
>>  			if (++curvec == last_affv)
>>  				curvec = firstvec;
>>  		}

Do you have any comments?

Rei