Date:   Wed, 15 Dec 2021 12:33:28 +0800
From:   Ming Lei <ming.lei@redhat.com>
To:     Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
Cc:     tglx@linutronix.de, hch@lst.de, kbusch@kernel.org,
        linux-kernel@vger.kernel.org, maz@kernel.org, ming.lei@redhat.com
Subject: Re: [PATCH] irq: consider cpus on nodes are unbalanced
Message-ID: <YblwGHAom8qkq4PW@T590>
References: <878rxdl55u.ffs@tglx>
 <20211215015711.28188-1-yamamoto.rei@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211215015711.28188-1-yamamoto.rei@jp.fujitsu.com>
Precedence: bulk

On Wed, Dec 15, 2021 at 10:57:11AM +0900, Rei Yamamoto wrote:
> On Wed, Nov 24 2021 at 20:33, Thomas Gleixner wrote:
> > Cc'ing a few people who worked on this code.
> >
> >> If cpus on a node are offline at boot time, there are
> >> difference in the number of nodes between when building affinity
> >> masks for present cpus and when building affinity masks for possible
> >> cpus.

There is always difference between the two number of nodes, the 1st is
node number covering present cpus, and the 2nd one is the node number
covering other possible cpus not spread.

>> This patch fixes 2 problems caused by the difference of the

Is there any user visible problem?

> >> number of nodes:
> >>
> >>  - If some unused vectors remain after building masks for present cpus,

We just select a new vector for starting the spread if un-allocated
vectors remains, but the number for allocation is still numvecs. We hope both
present cpus and non-present cpus can be balanced on each vector, so that each
vector may get present cpu allocated.

> >>    remained vectors are assigned for building masks for possible cpus.
> >>    Therefore "numvecs <= nodes" condition must be
> >>    "vecs_to_assign <= nodes_to_assign". Fix this problem by making this
> >>    condition appropriate.
> >>
> >>  - The routine of "numvecs <= nodes" condition can overwrite bits of
> >>    masks for present cpus in building masks for possible cpus. Fix this
> >>    problem by making CPU bits, which is not target, not changing.

'numvecs' is always the total number of vectors for assigning CPUs, if
the number is <= nodes, we just assign interested cpus in the whole
node into each vector until all interested cpus are allocated out.

 
> Do you have any comments?

Not see issues in current way, or can you explain a bit the real
user visible problem in details?

Thanks,
Ming