Date:   Tue, 14 Dec 2021 20:36:57 -0800
From:   Davidlohr Bueso <dave@stgolabs.net>
To:     Waiman Long <longman@redhat.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
        linux-mm@kvack.org,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH-next v3] mm/memcg: Properly handle memcg_stock access for
 PREEMPT_RT
Message-ID: <20211215043657.ngmxlk6rgc2ysbmz@offworld>
Mail-Followup-To: Waiman Long <longman@redhat.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
        linux-mm@kvack.org,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20211214144412.447035-1-longman@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20211214144412.447035-1-longman@redhat.com>
User-Agent: NeoMutt/20201120
Precedence: bulk

On Tue, 14 Dec 2021, Waiman Long wrote:

>@@ -2189,7 +2194,7 @@ static void drain_local_stock(struct work_struct *dummy)
>	 * drain_stock races is that we always operate on local CPU stock
>	 * here with IRQ disabled
>	 */
>-	local_irq_save(flags);
>+	local_lock_irqsave(&memcg_stock.lock, flags);
>
>	stock = this_cpu_ptr(&memcg_stock);
>	drain_obj_stock(&stock->irq_obj);

So here there is still the problem that you can end up taking sleeping locks
with irqs disabled via obj_cgroup_put() >> obj_cgroup_release() - ie: the
percpu_ref_switch_lock and css_set_lock. It had occurred to me to promote
the former to a raw spinlock, but doubt we can get away with the latter.

Thanks,
Davidlohr