Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 362B2C433EF for ; Wed, 15 Dec 2021 04:49:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239774AbhLOEtW convert rfc822-to-8bit (ORCPT ); Tue, 14 Dec 2021 23:49:22 -0500 Received: from out03.mta.xmission.com ([166.70.13.233]:38892 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbhLOEtU (ORCPT ); Tue, 14 Dec 2021 23:49:20 -0500 Received: from in01.mta.xmission.com ([166.70.13.51]:55648) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mxMEB-00FT0F-NB; Tue, 14 Dec 2021 21:49:19 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:59552 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mxME9-00CZ9e-3J; Tue, 14 Dec 2021 21:49:19 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Rong Chen Cc: kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org References: <202112140949.Uq5sFKR1-lkp@intel.com> <87k0g7t7ry.fsf@email.froward.int.ebiederm.org> <2af5f2f0-b2db-35e3-2d7a-7fa512db19af@intel.com> Date: Tue, 14 Dec 2021 22:48:32 -0600 In-Reply-To: <2af5f2f0-b2db-35e3-2d7a-7fa512db19af@intel.com> (Rong Chen's message of "Wed, 15 Dec 2021 09:35:43 +0800") Message-ID: <8735mutqvz.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-XM-SPF: eid=1mxME9-00CZ9e-3J;;;mid=<8735mutqvz.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/YgnsCOvPnJZVmeWkLiprg0pftoJSZ+qI= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [kbuild-all] Re: [ebiederm-user-namespace:signal-for-v5.17 4/12] arch/x86/kernel/dumpstack.o: warning: objtool: oops_end() falls through to next function show_opcodes() X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rong Chen writes: > On 12/15/21 01:29, Eric W. Biederman wrote: >> kernel test robot writes: >> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git signal-for-v5.17 >>> head: 6b1248798eb6f6d5285db214299996ecc5dc1e6b >>> commit: 0e25498f8cd43c1b5aa327f373dd094e9a006da7 [4/12] exit: Add and use make_task_dead. >>> config: x86_64-randconfig-a011-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140949.Uq5sFKR1-lkp@intel.com/config) >>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 >>> reproduce (this is a W=1 build): >>> # https://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git/commit/?id=0e25498f8cd43c1b5aa327f373dd094e9a006da7 >>> git remote add ebiederm-user-namespace https://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git >>> git fetch --no-tags ebiederm-user-namespace signal-for-v5.17 >>> git checkout 0e25498f8cd43c1b5aa327f373dd094e9a006da7 >>> # save the config file to linux build tree >>> mkdir build_dir >>> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kernel/ kernel/ lib/kunit/ >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> All warnings (new ones prefixed by >>): >>> >>>>> lib/kunit/kunit-example-test.o: warning: objtool: .text.unlikely: unexpected end of section >>> -- >>>>> arch/x86/kernel/dumpstack.o: warning: objtool: oops_end() falls through to next function show_opcodes() >> I am confused. This change patches objtool to rename >> rewind_stack_and_do_exit to rewind_stack_and_make_dead in the list >> global_noreturns in tools/objtool/check.c >> >> There is no other change to oops_end other than that renaming. >> >> Did the robot somehow mange to run an old version of objtool while >> building and this get this error? >> >> I tried and I am not currently able to reproduce this error. Do you >> have any additional pointers on how I might reproduce this? > > Hi Eric, > > The reproduce step in report based on a full build, I can reproduce > the warnings with the below command: > >   make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash Any chance you could do "make arch/x86/kernel/dumpstack.s" and send it to me? I want to see what code is in your oops_end. It really does not make sense that simply renaming a function would trigger this error. I did a full build (on debian 10 with gcc-8.3.0) and I did not manage to reproduce this. In a bit I will try with a newer debian and see if I can get the issue to reproduce. Still it does not make sense to me that a simple rename would trigger this error. Eric