From:   Hongxing Zhu <hongxing.zhu@nxp.com>
To:     Vinod Koul <vkoul@kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>
CC:     "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Subject: RE: [PATCH] phy: freescale: pcie: explictly add bitfield.h
Thread-Topic: [PATCH] phy: freescale: pcie: explictly add bitfield.h
Thread-Index: AQHX8Xo7K05H1Uu+UEi1P50XzJU58awzFowQ
Date:   Wed, 15 Dec 2021 06:29:26 +0000
Message-ID: <AS8PR04MB86765D95A0E42CED2C5D9B4D8C769@AS8PR04MB8676.eurprd04.prod.outlook.com>
References: <20211215060834.921617-1-vkoul@kernel.org>
In-Reply-To: <20211215060834.921617-1-vkoul@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bmtbohuFcV+A8IhErMhj20LC6hCyH820nb9ui4apSBog9BM/O0N6HBCxEaXk?=
 =?us-ascii?Q?xM0d7JNqsF1Ibe8MSBzuYWhcEutkkCOsJa4h5KCi8sUOjXkJlAYfA9GmEPd9?=
 =?us-ascii?Q?7wQpFBXJAsVo2drGs6nFYc3uce9+S051kEdibkc8YxmP83kpnm9iJpyPODWq?=
 =?us-ascii?Q?vcpYzed9gEyPgmzj+t2NXChOvERFxm1G/S2ioxplaUUmzntKYjUTGHG0OIFG?=
 =?us-ascii?Q?jbvABEUNWWPOl64GgAKNxXzIGcnmuMfCuLhmH7YWwT0IvHyDXcH3WCryxCzk?=
 =?us-ascii?Q?6HBrSkVs1yiXb3QbhWiRJZ/dLVXArcuiHDun8kGjP+fRcF88qwRX/m9ZniAJ?=
 =?us-ascii?Q?HMlNckojD/2voRLcF24+fMpAw4Fmd/jPujkoWu5/flGEG5EwW6uwkrr1SzwE?=
 =?us-ascii?Q?2hwGaPYvZFNA1zcRp2lynkyCENnb1PtM8U8+V1S0SXAwOlrPmXtg1JixlmFT?=
 =?us-ascii?Q?tCUkRcH/ogyJVHcyQPIAmcWpdbz9pcYkjmjpYsGEgHc5qdHQwMEfbnapPNWL?=
 =?us-ascii?Q?k2L8Y1XmKDLXylMGGCZpBTetJqMSXo6+//NMd2x9iaql3Hg/AAGgPnXV4W2R?=
 =?us-ascii?Q?P2paPGw9DjpBIzAAse8eWgWGYDUgqBkJJDRO+kleoNZwwrIduju8tTeptt0n?=
 =?us-ascii?Q?+lwheLUazBPaBShGQ5LvN79KgvPHaUlIG+p2StTJCsWTyeFp7fre4R1Zx56Q?=
 =?us-ascii?Q?GRE69BeDUzIlRJh/8hoeNyqz+S4/TXE5mw/DIG/5c6KPBv02o6XZ+A+tEVSO?=
 =?us-ascii?Q?8RK3Ja3/fU3yMe2S3EE81JGnCBS9+yV6ew0GQZVVP3Y0NgKJ6LrX9sfzsC6s?=
 =?us-ascii?Q?DUKQBG1W+i5qC8biqvLleecQ2PkBXePE2iL1fwa1QjuUbTyzOwYUZzsjmCHW?=
 =?us-ascii?Q?TOp/ClayLrDzriyXppV9eeeXRm0zMsDd1ftZGeSmrNXYI72//93eWGD3RiQ2?=
 =?us-ascii?Q?Eb5hkrdEG7c+H5N0JzvzKJBNZVvRX8rS473aGyLZOQKSw+cpYGjRn+Z1WM4+?=
 =?us-ascii?Q?jDnHkzKsjcyXCBYwXzxRZ+FHeS4+csGc/rF7iSy3cAgPi7UuFS67XAmYIDhc?=
 =?us-ascii?Q?pZrv87zOveJHmN7j7GSv1YJOyORmmMpDtd7EEx897Uh5KOtqXn3/wT58mQGc?=
 =?us-ascii?Q?Ja8gYkBYaeCDOkshRhzBco31X5isde6clrhsrUf4CeHvUCXKDA3WIVToT7fW?=
 =?us-ascii?Q?4R0xURYyi/13m6UKzuCmA0PZIsfVLKy1BMVnHEhLCASQWyatUMlmKwebo9KK?=
 =?us-ascii?Q?FYHoHpyfsx/QIrLOFtaXrvgU17OLZqICeFQPfkNr/Cf8dosMZkQDunbl7gCh?=
 =?us-ascii?Q?JtaHoPDig0KU+DcXyCs1E+kxaPgDM3IvtUXYUW4/SjwihKboYK4BeXk8uZQk?=
 =?us-ascii?Q?y1ZsxzemRbCf75utOFQ2O0JhND9O14aWbkM/cofCWC1RgJTzaAqzHEpjD0sC?=
 =?us-ascii?Q?/43A6b4sz2XYiRqaAR/Y8FO+U5fnNbigfxhFvgDTgw2Tv3dVwb6ceYNr314N?=
 =?us-ascii?Q?PERhvVZnRi8iAznU4YCVwo0NotfIj304+pj9TBh47s84BSEDA/0rbBDolNsC?=
 =?us-ascii?Q?k/JuVaeIV0tWnlJb7e89R8oEMyzPz7gQDi/7a4bS86uS7I7eLFI1e+SRd/FP?=
 =?us-ascii?Q?6A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8658d790-e456-4505-a53c-08d9bf943dcd
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 06:29:26.1264
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WX3cU7S5iYwtu3w/y44iUNpL21pPC2ekbistVaL0nrT8JJu57wSo+HKl4BHYkLGIPrRo+/g/gWGPMr22IdAgVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9141
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Wednesday, December 15, 2021 2:09 PM
> To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> <hongxing.zhu@nxp.com>
> Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel test robot <lkp@intel.com>
> Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
>=20
> kernel test robot complains about missing FIELD_PREP, so include
> bitfield.h for that
>=20
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=3Dimplicit-function-declaration]
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=3Dimplicit-function-declaration]
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> standalone phy driver")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks a lot for your help to fix it.
And I'm sorry about that I didn't capture this error in my local build and =
tests.

Best Regards
Richard Zhu

> ---
>  drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index f6502463d49a..04b1aafb29f4 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -3,6 +3,7 @@
>   * Copyright 2021 NXP
>   */
>=20
> +#include <linux/bitfield.h>
>  #include <linux/clk.h>
>  #include <linux/io.h>
>  #include <linux/iopoll.h>
> --
> 2.31.1