From:   Devesh Sharma <devesh.s.sharma@oracle.com>
To:     "cgel.zte@gmail.com" <cgel.zte@gmail.com>,
        "zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>
CC:     "dledford@redhat.com" <dledford@redhat.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: RE: [External] : [PATCH infiniband-next] drivers/infiniband: remove
 redundant err variable
Thread-Topic: [External] : [PATCH infiniband-next] drivers/infiniband: remove
 redundant err variable
Thread-Index: AQHX8Xnwbss9YZf1d0uHJXodl85i+KwzITKw
Date:   Wed, 15 Dec 2021 07:05:58 +0000
Message-ID: <CO6PR10MB56353FD77836D5605CDDB8DEDD769@CO6PR10MB5635.namprd10.prod.outlook.com>
References: <20211215060625.442082-1-chi.minghao@zte.com.cn>
In-Reply-To: <20211215060625.442082-1-chi.minghao@zte.com.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1jjG+evs/xOFpEoxzyQOl/y4WDNUOERfIKmDLiHuYjjrQT6lbgZRgm/fqddJ?=
 =?us-ascii?Q?vmBICU71q34e97XI51s+/i+hkWcMU9+LlnRpszwpUk+gyYv5VQyywilYTfwd?=
 =?us-ascii?Q?sPwtcG6h8/Knhz7KkOtMKZilOuft0Y9276gJAz8rsIKdDU/SBIJa8SL4BhUi?=
 =?us-ascii?Q?nFfRjgRMLG4ZbcNfa1+f7RC8NTRJEyczk8duGFZZYHt3K+QVBFS4Lka62G7q?=
 =?us-ascii?Q?XLQqNEp9jzICUvRNXngIlXJnVLRAW1+eDLnLAqCi4OmXoENIqiwhDV9Yox84?=
 =?us-ascii?Q?/+1+p75mNqoWA5nAFth8GsffDHQaT5m9izOGFclHF8lJfmIO2E90sxif/M5N?=
 =?us-ascii?Q?/LkG5xAQnIJ/j5RF005QCbXlaWdcHvWlYh0fSD+WFdCcAQ/k6rdptOzKWMf2?=
 =?us-ascii?Q?w5MZRtG406/10UYx129Gnu794uyRu9G7O73PknEOngp/azLbfigT4C/9wuG2?=
 =?us-ascii?Q?Zsn5wm+FQwpiCSxvHhdVi4srUot7IQlUifJ6Zc7eEw1iJqhMRj8dcHknPcOA?=
 =?us-ascii?Q?E/7uePDxQoXAuHJXmmNJ9R3WIRnsoKKX9UAlk+ZRnFzJpVdWoulNEz8YGpqA?=
 =?us-ascii?Q?tuv5whReFVYPFTZ1EfL7h1tpqlZMIRyC378M2E+YrkEDDJkptT6e5sgmT4Oq?=
 =?us-ascii?Q?uHtrPS75wSx+MVBwTrCef6Gwb+qWESoCQwhn4ho88mL1eJ0pF1yqfpwdYxd3?=
 =?us-ascii?Q?jIwz9UKZsDKawXZDjn+dXqpkQeBnqsVbLQZYBLJvTIU58QmV98b1gVzGLQDw?=
 =?us-ascii?Q?siDAWA9M8GIdExSGbW0bn2PEQmjqkAEFGx/MU0/VhDlmbyj347fQ4pjnJL32?=
 =?us-ascii?Q?/npsmN5WiWwwqRpSILxp64fPp8CjYd9XDYGD0H1Say6hwwXTO8zWNs9uBU0v?=
 =?us-ascii?Q?vHMwONk3/tDGRlRg02EfuUVfr9ZXgmtWPMq/3pJ8CxUzy7hl4aVfY196YrXi?=
 =?us-ascii?Q?IYTuP6hBwnfQIg01HGbawc/pXSaEVAKRbnSE+3732xpobzRXFspI/YImhvNK?=
 =?us-ascii?Q?FPNPEveIQFWbKyPGRSNNTFzqAhm90/ESVdIrLzQcauGdARbaaAUWlqHPurSG?=
 =?us-ascii?Q?9Sbzt25LYceqzDw90paHLGPM+yh00Jan2ZGS00oVuEzUzogH3UYXR6xYvNLH?=
 =?us-ascii?Q?KpWcbKZdjnevMUPjBw15z8iT/GGRk7qnoE4g2HE1AMyJ9vH79DYmOcNiqAQ5?=
 =?us-ascii?Q?UEyGKWJR9ZClYScGdsZHnVi2C38N+42JSsT1DsKIVZwUEk51PqlGeu+7v84T?=
 =?us-ascii?Q?R6FmK2qUTkriIECA3nRI8JMXgfIt8WmyRrqxSXMjLcm1bnKBevmsyGjd4EWv?=
 =?us-ascii?Q?iQYHAZ3Rj4saYMwpP2hdWoUYXgvaNbCkKx5g2XpKlUpaRS043vxpj4BmRQnd?=
 =?us-ascii?Q?Eg1VjhD2bbZS08vgt15zqrljir2JXWqD38lbjXtnAb/1RcITf1i/27+FmRwb?=
 =?us-ascii?Q?i/zAe6GWqF32Jpx4rseFuMEFtE/kcbGaprHvqlkfcdSCR80qcfab1E6lG0XB?=
 =?us-ascii?Q?3cEt0oGAEtMSGZLUzmgzb0qqRgyxfpDmCswGuXjzGG5Sfl6fA4Jb3VmYw1eF?=
 =?us-ascii?Q?hnFwGjcB28R9OgvqQsEmJE3OQLs/sjnCqsDiRPzxq1qaleb+BgkIVU9Dd7Q2?=
 =?us-ascii?Q?+jCrEJjr8TXrP66Ts2GlS+X0PFJkNpHTm7wdvC8n/KZ+toDkQVLRauR7D6do?=
 =?us-ascii?Q?N5r0oA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5635.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f19dcc96-b376-4c6d-23e8-08d9bf99585a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 07:05:58.1575
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xBr2/2vYLlruQ9TyBX8O0heNAG3bCuRKiy404VDQWebRXlfvmUaWC/N4gWek+7sK9AqUCt137jytoQfmDxytJZJxQpw+7P9v2kstobR0r7E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5805
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10198 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 mlxlogscore=736 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112150039
X-Proofpoint-ORIG-GUID: 9Ed-nBoOKmPEmPDkdAL9WKRwWUBbo4XM
X-Proofpoint-GUID: 9Ed-nBoOKmPEmPDkdAL9WKRwWUBbo4XM
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Wednesday, December 15, 2021 11:36 AM
> To: zyjzyj2000@gmail.com
> Cc: dledford@redhat.com; jgg@ziepe.ca; linux-rdma@vger.kernel.org; linux-
> kernel@vger.kernel.org; Minghao Chi <chi.minghao@zte.com.cn>; Zeal
> Robot <zealci@zte.com.cn>
> Subject: [External] : [PATCH infiniband-next] drivers/infiniband: remove


Change the subject line
[PATCH for-next] RDMA/rxe: ....

> redundant err variable
>=20
> From: Minghao Chi <chi.minghao@zte.com.cn>
>=20
> Return value directly instead of taking this in another redundant variabl=
e.
>=20
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>=20
>  int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)  {
> -	int err;
>  	unsigned char ll_addr[ETH_ALEN];
>=20
>  	ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> -	err =3D dev_mc_add(rxe->ndev, ll_addr);
>=20
> -	return err;
> +	return dev_mc_add(rxe->ndev, ll_addr);
>  }
>=20
>  int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)  {
> -	int err;
>  	unsigned char ll_addr[ETH_ALEN];
>=20
>  	ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> -	err =3D dev_mc_del(rxe->ndev, ll_addr);
>=20
> -	return err;
> +	return dev_mc_del(rxe->ndev, ll_addr);
>  }
>=20
>  static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1