Message-ID: <8541216a98a1a68fe6c339096e5e148a40b414e2.camel@perches.com>
Subject: Re: [PATCH] media: i2c: ov8865: Neaten unnecessary indentation
From:   Joe Perches <joe@perches.com>
To:     Sakari Ailus <sakari.ailus@iki.fi>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        linux-media <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Wed, 15 Dec 2021 00:07:14 -0800
In-Reply-To: <Ybmgwo/6bQXtaT35@valkosipuli.retiisi.eu>
References: <c6189daaac183ddf51da1444c597d8577c1ac416.camel@perches.com>
         <Ya9SlGo5HZpOXTmZ@valkosipuli.retiisi.eu>
         <f02e4204284af7ea848027a67cb1e907fb7d4403.camel@perches.com>
         <Ybmgwo/6bQXtaT35@valkosipuli.retiisi.eu>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-12-15 at 10:01 +0200, Sakari Ailus wrote:
> Hi Joe
> 
> On Tue, Dec 07, 2021 at 06:47:45AM -0800, Joe Perches wrote:
> > On Tue, 2021-12-07 at 14:24 +0200, Sakari Ailus wrote:
> > > Hi Joe (and Paul),
> > 
> > > I guess this patch is fine as such but there seems to be a problem in error
> > > handling here: all regulators are disabled if there's a problem enabling
> > > one of them.
> > > 
> > > Would it be possible to fix this as well?
> > 
> > I've no hardware to test, so I've no idea if that's the right thing to do.
> 
> I don't have the hardware either.
> 
> But I can tell that you shouldn't disable a regulator you haven't enabled
> to begin with. Bugs (fixes of which probably should go to stable trees)
> need to be fixed before reworking the code.

I'm just fixing the ugly code.
You are welcome to fix what you believe to be logical defects.