From:   "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Oleksij Rempel <o.rempel@pengutronix.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>
Subject: RE: [BUG] net: phy: genphy_loopback: add link speed configuration
Thread-Topic: [BUG] net: phy: genphy_loopback: add link speed configuration
Thread-Index: AdfwtmkvCyrAW5M4S3mERBKDxICdHAAGBHqAADANSQA=
Date:   Wed, 15 Dec 2021 08:36:23 +0000
Message-ID: <CO1PR11MB477111F4B2AF4EFA61D9B7F4D5769@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <CO1PR11MB4771251E6D2E59B1B413211FD5759@CO1PR11MB4771.namprd11.prod.outlook.com>
 <YbhmTcFITSD1dOts@lunn.ch>
In-Reply-To: <YbhmTcFITSD1dOts@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DvKbqU5nXMs26WsJyCipYaAcZDD9vHcEvDCUsQhNkk41flzj35q2jxsZ6FZI?=
 =?us-ascii?Q?Il1k+7/9gWZXQdCTiRTsnCtgSzB179UDpN//ngmqqixZckgn9Qh+oay06K9u?=
 =?us-ascii?Q?dPn+6ef6VmWgcwgMmtgpl12lbRnRhGWs1t2OLwyC7uozhOhR+4Adqt93lh6C?=
 =?us-ascii?Q?8ncs8DuplCjWetvr5YuBCBti/rH6IXZMX6z2wX/IXZb8TP1sWkSZNZ87Ggkk?=
 =?us-ascii?Q?wX3wgDL/zrpFZg946vDoBpjrj3UE3wxXz7QCXUnfm50jxT9UOOL3vMJyy9HD?=
 =?us-ascii?Q?PucKROTEjMHel2p2lTlP/hYK+wEwAV8TOsqYgGq9LcRVyepHn/Uzls8q1SJN?=
 =?us-ascii?Q?jJduFLX7IDv6u02g2+IpSePvgAM//MW/ww/IbBvSljBg0rjhYFiZKvlWBREe?=
 =?us-ascii?Q?+tw0GNGl9KkTrKWRu/pPZmJiqSnYWEHweS8RV9FJPgAE8xxXgJuMfJa9VVYm?=
 =?us-ascii?Q?LQXqZySBy3FmxDt8agDicfcfQCpQ/ICVHwfownRZ7PmkbUmKvL7N69UKvRJU?=
 =?us-ascii?Q?BwxYpzHqJd8jYiv3NGXHYRDtUS4Qg/qa/9jSo2p9mJ8zsXljmUY05qE5iCii?=
 =?us-ascii?Q?LYIMVy+wR+NNZWPBq26D0HUibaLVP+HAe04TJTF2qGQJF4qbetkvZA5eZxUo?=
 =?us-ascii?Q?o6u5EI3pSjFEfRCOixahxs9VWs20jLVPQs7pHLXjBI8sJJ/kKc7tYlwB/D5l?=
 =?us-ascii?Q?hKMtlvm0Mk3XLOKQE1lS+Kt1J3GADvBOXORb+j0SWSHVN9DQr05K+jDULuvS?=
 =?us-ascii?Q?s6uBKspr6uIQ2DmjAUs9+VbmccyOZHiFCn9L9kTWcnoUiS44M8KUsnC+1fjw?=
 =?us-ascii?Q?Xki5VHQluTvAAy/g7dZfIwBXv1dc4sXAoCqiwOMoSf7cBa6ZwFGmM/+7aIxz?=
 =?us-ascii?Q?tUwDhp4+y1ni1/7Vgq7eV2E+uaJH0DSS4g/KZmmeke97YE1CcxzvQ7qFKTWK?=
 =?us-ascii?Q?PQb7V3zgtH4SPbkh+COyXUyF54BtBsD8MIeY3BdITR9p8KdEz7rJaeCkrDSm?=
 =?us-ascii?Q?j1bIJubC8SHGbhknsNm43ADFGmH9DTY7KHC1qMDfhIkN67zatA9Md8sNCLzc?=
 =?us-ascii?Q?D0jpP7YW7FN/qMvm5XCgM1JUmJPmBSM1qQ7yv7jxz+b1DfscZJFmwAFTM4H7?=
 =?us-ascii?Q?XApQzsASVfYSCYUOAhRgaLPyT4H9NhUe+sbO58fUSFYs3doh6q88l3sT/Aiy?=
 =?us-ascii?Q?N4GHNXp+Ct47caYzFwUw/7rdEK/Ox7VpQjyBz35nznFKEqAS/WXUujVKkNtM?=
 =?us-ascii?Q?vHhpc3NLYKXueQ33wH17Rz3tLwETmMorNixQO6iRLwGvtYcgxR0PusqqPUTQ?=
 =?us-ascii?Q?V/qaq0xIq+bM+GiVG+ZZev4n61UAHRK9f+AfbmmiSzegpp6kiX/6PNDwdzNE?=
 =?us-ascii?Q?JPDefKnDdgIRZ2yZCusAzHJKrmQdtE6lN6cBXNMDM2AUOtNOEmR4CImsThZQ?=
 =?us-ascii?Q?uCEqaQBr6Pw7DVSEQe+44tA3FcVKsMAp+GKBSFa7UpfQ+i5zIOdjaYnhHXy/?=
 =?us-ascii?Q?vVgcdghAOXETALNztizIdVpQ8wf6+VGl3qrVJSdT+2pg5OrSeWT3O5kpRyC1?=
 =?us-ascii?Q?HCJpwavouu4vcMV2Mmww7D9HlFC1PJPwadZXQTTJUGN+AA/JDBgpqXyH1nyN?=
 =?us-ascii?Q?WMY5147OtTnOSwm6Zy3VVUjiSwJX6PYKOPSEIKVxs843zigWfWHSncWVJRSo?=
 =?us-ascii?Q?ovEexGeL4dPiHFjzON+8QMOw8Z4Z/JnaxXcHTpAWiy7M7r8a?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5330d040-96e8-415c-bb67-08d9bfa5fa65
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 08:36:24.0080
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qubVJLKPO5SuiWnQuxjnrxBANeV9STck+x3vjYLptOx+nDrMKj2wc3xMkjmjPBta/TXGXwK4kjsAfxEAjHzXDEAMuc/cHi0znbbqbhK73lq9UqVaWsu1/dzXBIF0TM88
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2143
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, December 14, 2021 5:39 PM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Voon, Weifeng <weifeng.voon@intel.com>;
> Wong, Vee Khee <vee.khee.wong@intel.com>
> Subject: Re: [BUG] net: phy: genphy_loopback: add link speed configuratio=
n
>=20
> On Tue, Dec 14, 2021 at 07:00:37AM +0000, Ismail, Mohammad Athari wrote:
> > Hi Oleksij,
> >
> > "net: phy: genphy_loopback: add link speed configuration" patch causes
> Marvell 88E1510 PHY not able to perform PHY loopback using ethtool
> command (ethtool -t eth0 offline). Below is the error message:
> >
> > "Marvell 88E1510 stmmac-3:01: genphy_loopback failed: -110"
>=20
> -110 is ETIMEDOUT. So that points to the phy_read_poll_timeout().
>=20
> Ah, that points to the fact the Marvell PHYs are odd. You need to perform=
 a
> software reset after changing some registers to actually execute the chan=
ge.
>=20
> As a quick test, please could you try:
>=20
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 74d8e1dc125f..b45f3ffc7c7f 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -2625,6 +2625,10 @@ int genphy_loopback(struct phy_device *phydev,
> bool enable)
>=20
>                 phy_modify(phydev, MII_BMCR, ~0, ctl);
>=20
> +               ret =3D genphy_soft_reset(phydev);
> +               if (ret < 0)
> +                       return ret;
> +
>                 ret =3D phy_read_poll_timeout(phydev, MII_BMSR, val,
>                                             val & BMSR_LSTATUS,
>                                     5000, 500000, true);
>=20
> If this fixes it for you, the actual fix will be more complex, Marvell ca=
nnot use
> genphy_loopback, it will need its own implementation.

Thanks for the suggestion. The proposed solution also doesn't work. Still g=
et -110 error.

-Athari-

>=20
>        Andrew